[v9.x bugfix] timers: fix a bug in error handling #20025
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a timeout within a list of timeouts (that consists of only that specific timeout) throws during its execution, it's possible for the TimerWrap handle to become shared between both that list and an unref'd timeout created in the future. This fixes the bug by extending error handling in timeout execution to check for whether the current list is empty and if so do cleanup on it.
apapirovski
added
the
timers
|
@nodejs/release Let me know if we're not doing another 9.x release and I'll reopen this against 8.x. |
Fishrock123
approved these changes
Apr 16, 2018
|
cc @nodejs/timers |
|
ping @nodejs/release re: above. Should this get reopened against v8.x? Seems like 9.x is not getting another release, unless I'm mistaken. |
|
@MylesBorins if you're making an 8.x release, I would appreciate this getting landed on 9.x staging so I can backport it to 8.x for the next release. (This doesn't apply to 10.x as it was fixed via a semver-major PR.) But let me know if we should just open against 8.x. Not sure the status of 9.x currently. |
|
@apapirovski this should likely target 8.x at this point |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug fix for v9.x that can also be backported to v6.x and v8.x. This was fixed in master via a semver-major commit which can't be backported, at least not until we confirm that it doesn't cause unrelated issues.
When a timeout within a list of timeouts (that consists of only that specific timeout) throws during its execution, it's possible for the TimerWrap handle to become shared between both that list and an unref'd timeout created in the future. This fixes the bug by extending error handling in timeout execution to check for whether the current list is empty and if so do cleanup on it.
Fixes: #19970
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes