Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fix CJS/ESM toggle on small screens #43506

Merged
merged 4 commits into from
Jun 27, 2022

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jun 20, 2022

Alternative to #43495. Opening as draft because all.html changes are not yet implemented, I'd like to first get some feedback whether that's something we want to do or not.

Fixes: #43468
Co-authored-by: Moshe Atlow [email protected]

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Jun 20, 2022
@aduh95 aduh95 marked this pull request as ready for review June 22, 2022 14:35
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 23, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 27, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/43506
FetchError: Invalid response body while trying to fetch https://api.github.com/graphql: Premature close
    at consumeBody (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:234:60)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async Response.text (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:158:18)
    at async Request.json (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/lib/request.js:51:18)
    at async Request.query (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/lib/request.js:109:20)
    at async Request.queryAll (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/lib/request.js:136:20)
    at async Request.gql (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/lib/request.js:66:22)
    at async PRData.getComments (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/lib/pr_data.js:97:21)
    at async Promise.all (index 2)
    at async Promise.all (index 1) {
  type: 'system',
  errno: 'ERR_STREAM_PREMATURE_CLOSE',
  code: 'ERR_STREAM_PREMATURE_CLOSE',
  erroredSysCall: undefined
}
https://github.com/nodejs/node/actions/runs/2570249122

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jun 27, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 27, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/43506
✔  Done loading data for nodejs/node/pull/43506
----------------------------------- PR info ------------------------------------
Title      tools: fix CJS/ESM toggle on small screens (#43506)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:cjs-esm-toggle-small-screens -> nodejs:main
Labels     doc, tools, author ready
Commits    4
 - tools: fix CJS/ESM toggle on small screens
 - fixup! tools: fix CJS/ESM toggle on small screens
 - fixup! tools: fix CJS/ESM toggle on small screens
 - fixup! tools: fix CJS/ESM toggle on small screens
Committers 2
 - Antoine du Hamel 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/43506
Fixes: https://github.com/nodejs/node/issues/43468
Reviewed-By: LiviaMedeiros 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43506
Fixes: https://github.com/nodejs/node/issues/43468
Reviewed-By: LiviaMedeiros 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 20 Jun 2022 13:52:42 GMT
   ✔  Approvals: 1
   ✔  - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/43506#pullrequestreview-1017419635
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 43506
From https://github.com/nodejs/node
 * branch                  refs/pull/43506/merge -> FETCH_HEAD
✔  Fetched commits as bb30e2da7a31..40906b8045ff
--------------------------------------------------------------------------------
[main 65dda400d8] tools: fix CJS/ESM toggle on small screens
 Author: Antoine du Hamel 
 Date: Mon Jun 20 14:36:00 2022 +0200
 3 files changed, 26 insertions(+), 1 deletion(-)
[main 97a637410d] fixup! tools: fix CJS/ESM toggle on small screens
 Author: Antoine du Hamel 
 Date: Wed Jun 22 16:33:08 2022 +0200
 3 files changed, 22 insertions(+), 14 deletions(-)
 create mode 100644 tools/doc/buildCSSForFlavoredJS.mjs
[main 7f3dd1a10a] fixup! tools: fix CJS/ESM toggle on small screens
 Author: Antoine du Hamel 
 Date: Thu Jun 23 17:07:40 2022 +0200
 1 file changed, 43 insertions(+), 1 deletion(-)
[main 1f3a1ab9fb] fixup! tools: fix CJS/ESM toggle on small screens
 Author: Antoine du Hamel 
 Date: Thu Jun 23 19:40:27 2022 +0200
 1 file changed, 1 insertion(+)
   ✔  Patches applied
There are 4 commits in the PR. Attempting autorebase.
Rebasing (2/5)
Rebasing (3/5)
Rebasing (4/5)
Rebasing (5/5)

Executing: git node land --amend --yes
⚠ Found Fixes: #43468, skipping..
--------------------------------- New Message ----------------------------------
tools: fix CJS/ESM toggle on small screens

Fixes: #43468
Co-authored-by: Moshe Atlow [email protected]

PR-URL: #43506
Reviewed-By: LiviaMedeiros [email protected]

[detached HEAD 06824557dc] tools: fix CJS/ESM toggle on small screens
Author: Antoine du Hamel [email protected]
Date: Mon Jun 20 14:36:00 2022 +0200
5 files changed, 78 insertions(+), 2 deletions(-)
create mode 100644 tools/doc/buildCSSForFlavoredJS.mjs

Successfully rebased and updated refs/heads/main.
✖ 06824557dcc91ed10750c122d7ed29043de52bce
✔ 1:7 Valid fixes URL. fixes-url
✖ 2:0 Co-authored-by must be a trailer co-authored-by-is-trailer
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 4:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length

ℹ Please fix the commit message and try again.

https://github.com/nodejs/node/actions/runs/2570321424

@aduh95 aduh95 merged commit 7cbcc4f into nodejs:main Jun 27, 2022
@aduh95
Copy link
Contributor Author

aduh95 commented Jun 27, 2022

Landed in 7cbcc4f

@aduh95 aduh95 deleted the cjs-esm-toggle-small-screens branch June 27, 2022 16:31
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43506
Co-authored-by: Moshe Atlow <[email protected]>
Fixes: #43468
Reviewed-By: LiviaMedeiros <[email protected]>
targos pushed a commit that referenced this pull request Jul 20, 2022
PR-URL: #43506
Co-authored-by: Moshe Atlow <[email protected]>
Fixes: #43468
Reviewed-By: LiviaMedeiros <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #43506
Co-authored-by: Moshe Atlow <[email protected]>
Fixes: #43468
Reviewed-By: LiviaMedeiros <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#43506
Co-authored-by: Moshe Atlow <[email protected]>
Fixes: nodejs/node#43468
Reviewed-By: LiviaMedeiros <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CJS/ESM toggle broken on mobile
3 participants