Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update TLS trace tests for OpenSSL >= 3.2 #53229

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

richardlau
Copy link
Member

Update tests to allow for a slight change to the TLS trace messages starting from OpenSSL 3.2.

Refs: openssl/openssl@45aac10

Update tests to allow for a slight change to the TLS trace messages
starting from OpenSSL 3.2.

Refs: openssl/openssl@45aac10
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 31, 2024
@richardlau
Copy link
Member Author

cc @nodejs/crypto

Copy link
Member

@pimterry pimterry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pimterry pimterry added the request-ci Add this label to start a Jenkins CI on a PR. label May 31, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 31, 2024
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@richardlau richardlau added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 1, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 2, 2024
@nodejs-github-bot nodejs-github-bot merged commit da0f192 into nodejs:main Jun 2, 2024
66 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in da0f192

@richardlau richardlau deleted the openssl32_testfix branch June 2, 2024 18:07
targos pushed a commit that referenced this pull request Jun 3, 2024
Update tests to allow for a slight change to the TLS trace messages
starting from OpenSSL 3.2.

Refs: openssl/openssl@45aac10
PR-URL: #53229
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jun 7, 2024
sophonieb pushed a commit to sophonieb/node that referenced this pull request Jun 20, 2024
Update tests to allow for a slight change to the TLS trace messages
starting from OpenSSL 3.2.

Refs: openssl/openssl@45aac10
PR-URL: nodejs#53229
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
Update tests to allow for a slight change to the TLS trace messages
starting from OpenSSL 3.2.

Refs: openssl/openssl@45aac10
PR-URL: nodejs#53229
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
Update tests to allow for a slight change to the TLS trace messages
starting from OpenSSL 3.2.

Refs: openssl/openssl@45aac10
PR-URL: #53229
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
Update tests to allow for a slight change to the TLS trace messages
starting from OpenSSL 3.2.

Refs: openssl/openssl@45aac10
PR-URL: #53229
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Sep 24, 2024
Update tests to allow for a slight change to the TLS trace messages
starting from OpenSSL 3.2.

Refs: openssl/openssl@45aac10
PR-URL: nodejs#53229
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
richardlau added a commit to aduh95/node that referenced this pull request Sep 27, 2024
Update tests to allow for a slight change to the TLS trace messages
starting from OpenSSL 3.2.

Refs: openssl/openssl@45aac10
PR-URL: nodejs#53229
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants