tools: make choco install script readable

[RedYetiDev]

This PR improves the readability of the chocolatey install script by splitting the long command into multiple lines.

[sepehrst]

Trailing backticks cannot be used here as the PowerShell command is invoked in the context of a batch file. The trailing caret ^ (strictly the last character on the line) is the line continuation character for batch scripts, unless an unpaired double quote " is present on the line, in which case the caret is treated as a literal character, even without a closing quote.

[RedYetiDev]

Trailing backticks cannot be used here as the PowerShell command is invoked in the context of a batch file. The trailing caret ^ (strictly the last character on the line) is the line continuation character for batch scripts, unless an unpaired double quote " is present on the line, in which case the caret is treated as a literal character, even without a closing quote.

" are not used in the newlines, so what is the issue?

[sepehrst]

" are not used in the newlines, so what is the issue?

The current issue is, in batch files, backticks can not be used as line continuation character. Carets ^ have to be used for that purpose.

(What I wrote about " was an additional explanation/caution about how double-quotes. in some circumstances, might silently cause problems and disturb the ^ rule for line continuation. It does not apply to your current modifications, but something to watch for)

[sepehrst]

"%SystemRoot%\System32\WindowsPowerShell\v1.0\powershell.exe" ^
-NoProfile ^
-InputFormat None ^

Ditto for rest of the lines

[RedYetiDev]

@nodejs/platform-windows to review the new changes

[RedYetiDev]

Hey, could someone start a CI so that this can land? (It needs a CI, right?)

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/62144/

[RedYetiDev]

CI LGTM

[RedYetiDev]

Can someone commit-queue this please?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/62747/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/62762/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/54002
✔  Done loading data for nodejs/node/pull/54002
----------------------------------- PR info ------------------------------------
Title      tools: make choco install script readable (#54002)
Author     Aviv Keller <[email protected]> (@RedYetiDev)
Branch     RedYetiDev:patch-86 -> nodejs:main
Labels     windows, install, tools, author ready, needs-ci, commit-queue-squash
Commits    2
 - tools: make choco install script readable
 - fix backticks
Committers 1
 - GitHub <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/54002
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/54002
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - fix backticks
   ℹ  This PR was created on Tue, 23 Jul 2024 10:55:23 GMT
   ✔  Approvals: 2
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/54002#pullrequestreview-2194777045
   ✔  - Stefan Stojanovic (@StefanStojanovic): https://github.com/nodejs/node/pull/54002#pullrequestreview-2196297478
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-09-25T14:41:26Z: https://ci.nodejs.org/job/node-test-pull-request/62762/
- Querying data for job/node-test-pull-request/62762/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/11061465059

[aduh95]

Landed in e8127db