repl: catch `\v` and `\r` in new-line detection #54512

RedYetiDev · 2024-08-22T20:48:50Z

Fixes #54504
Uses RegExpPrototypeExec (with \n, \r, and \v) rather than StringPrototypeIndexOf with \n.

aduh95 · 2024-08-22T22:06:25Z

Can you add a test?

codecov · 2024-08-22T22:09:14Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.24%. Comparing base (76edde5) to head (500c5ee).
Report is 18 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #54512      +/-   ##
==========================================
- Coverage   88.26%   88.24%   -0.03%     
==========================================
  Files         651      651              
  Lines      183894   183877      -17     
  Branches    35858    35857       -1     
==========================================
- Hits       162315   162255      -60     
- Misses      14882    14898      +16     
- Partials     6697     6724      +27

Files with missing lines	Coverage Δ
lib/internal/repl/utils.js	`95.74% <100.00%> (ø)`

... and 34 files with indirect coverage changes

mikesamuel · 2024-08-22T23:17:35Z

@RedYetiDev Thanks for the quick fix.

RedYetiDev · 2024-08-23T20:46:00Z

CC @nodejs/repl

BridgeAR

RSLGTM

Thank you for addressing this

VoltrexKeyva

RSLGTM.

nodejs-github-bot · 2024-08-29T07:08:34Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61643/

nodejs-github-bot · 2024-08-31T19:18:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61756/

RedYetiDev · 2024-08-31T20:00:17Z

Not sure why https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu2204_sharedlibs_withoutssl_x64/45823/testReport/junit/(root)/parallel/test_repl_preview_newlines/ failed the test?

RedYetiDev · 2024-08-31T20:01:18Z

Maybe this'll fix it?

RedYetiDev · 2024-09-04T21:23:17Z

Could someone start a new CI? Triagers can't start one without an approving review.

nodejs-github-bot · 2024-09-14T14:30:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62428/

nodejs-github-bot · 2024-09-21T15:51:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62627/

RedYetiDev · 2024-09-22T00:30:19Z

CI LGTM. This should be good to commit-queue?

nodejs-github-bot · 2024-09-23T20:22:59Z

Commit Queue failed

- Loading data for nodejs/node/pull/54512
✔  Done loading data for nodejs/node/pull/54512
----------------------------------- PR info ------------------------------------
Title      repl: catch `\v` and `\r` in new-line detection (#54512)
Author     Aviv Keller <[email protected]> (@RedYetiDev)
Branch     RedYetiDev:patch-106 -> nodejs:main
Labels     repl, author ready, needs-ci, commit-queue-squash
Commits    2
 - repl: catch `\v` and `\r` in new-line detection
 - disable if no inspector
Committers 2
 - RedYetiDev <[email protected]>
 - GitHub <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/54512
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/54512
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - disable if no inspector
   ℹ  This PR was created on Thu, 22 Aug 2024 20:48:50 GMT
   ✔  Approvals: 3
   ✔  - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/54512#pullrequestreview-2258269961
   ✔  - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/54512#pullrequestreview-2259289159
   ✔  - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/54512#pullrequestreview-2274130019
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-09-21T15:51:28Z: https://ci.nodejs.org/job/node-test-pull-request/62627/
- Querying data for job/node-test-pull-request/62627/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/11001786432

test/parallel/test-repl-preview-newlines.js

Co-authored-by: Antoine du Hamel <[email protected]>

RedYetiDev · 2024-09-23T23:34:29Z

I reverted the change suggested because JSON.stringify('\v') !== '"\\v"', which breaks the length of the character when rendered.

nodejs-github-bot · 2024-09-24T15:06:29Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62735/

RedYetiDev · 2024-09-24T17:08:11Z

CI is 🟢 (yay!)

nodejs-github-bot · 2024-09-24T20:48:40Z

Commit Queue failed

- Loading data for nodejs/node/pull/54512
✔  Done loading data for nodejs/node/pull/54512
----------------------------------- PR info ------------------------------------
Title      repl: catch `\v` and `\r` in new-line detection (#54512)
Author     Aviv Keller <[email protected]> (@RedYetiDev)
Branch     RedYetiDev:patch-106 -> nodejs:main
Labels     repl, author ready, needs-ci, commit-queue-squash
Commits    4
 - repl: catch `\v` and `\r` in new-line detection
 - disable if no inspector
 - fixup!
 - fixup! fixup!
Committers 1
 - RedYetiDev <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/54512
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/54512
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - repl: catch `\v` and `\r` in new-line detection
   ⚠  - disable if no inspector
   ⚠  - fixup!
   ⚠  - fixup! fixup!
   ℹ  This PR was created on Thu, 22 Aug 2024 20:48:50 GMT
   ✔  Approvals: 4
   ✔  - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/54512#pullrequestreview-2258269961
   ✔  - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/54512#pullrequestreview-2259289159
   ✔  - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/54512#pullrequestreview-2274130019
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/54512#pullrequestreview-2323267187
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-09-24T15:06:29Z: https://ci.nodejs.org/job/node-test-pull-request/62735/
- Querying data for job/node-test-pull-request/62735/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/11021667751

nodejs-github-bot · 2024-09-25T08:51:13Z

Landed in c6d20a0

PR-URL: #54512 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

PR-URL: nodejs#54512 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

PR-URL: #54512 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [node](https://nodejs.org) ([source](https://github.com/nodejs/node)) | patch | `20.18.0` -> `20.18.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>nodejs/node (node)</summary> ### [`v20.18.1`](https://github.com/nodejs/node/releases/tag/v20.18.1): 2024-11-20, Version 20.18.1 'Iron' (LTS), @marco-ippolito [Compare Source](nodejs/node@v20.18.0...v20.18.1) ##### Notable Changes - \[[`7a8992b2d6`](nodejs/node@7a8992b2d6)] - **doc**: add abmusse to collaborators (Abdirahim Musse) [#55086](nodejs/node#55086) ##### Commits - \[[`085c3441fe`](nodejs/node@085c3441fe)] - **assert**: show the diff when deep comparing data with a custom message (Giovanni) [#54759](nodejs/node#54759) - \[[`01f0b0e7b4`](nodejs/node@01f0b0e7b4)] - **benchmark**: adjust config for deepEqual object (Rafael Gonzaga) [#55254](nodejs/node#55254) - \[[`a45537269b`](nodejs/node@a45537269b)] - **benchmark**: rewrite detect-esm-syntax benchmark (Joyee Cheung) [#55238](nodejs/node#55238) - \[[`1a0d8ef64f`](nodejs/node@1a0d8ef64f)] - **benchmark**: add no-warnings to process.has bench (Rafael Gonzaga) [#55159](nodejs/node#55159) - \[[`2be5d611ce`](nodejs/node@2be5d611ce)] - **benchmark**: create benchmark for typescript (Marco Ippolito) [#54904](nodejs/node#54904) - \[[`a2aa4fa477`](nodejs/node@a2aa4fa477)] - **benchmark**: include ascii to fs/readfile (Rafael Gonzaga) [#54988](nodejs/node#54988) - \[[`09849105fe`](nodejs/node@09849105fe)] - **benchmark**: add dotenv benchmark (Aviv Keller) [#54278](nodejs/node#54278) - \[[`6b3c24dbad`](nodejs/node@6b3c24dbad)] - **buffer**: fix out of range for toString (Jason Zhang) [#54553](nodejs/node#54553) - \[[`f25a5b6dc4`](nodejs/node@f25a5b6dc4)] - **build**: use rclone instead of aws CLI (Michaël Zasso) [#55617](nodejs/node#55617) - \[[`0bbeb605de`](nodejs/node@0bbeb605de)] - **build**: fix notify-on-review-wanted action (Rafael Gonzaga) [#55304](nodejs/node#55304) - \[[`5b35836732`](nodejs/node@5b35836732)] - **build**: include `.nycrc` in coverage workflows (Wuli Zuo) [#55210](nodejs/node#55210) - \[[`f38d1e90e0`](nodejs/node@f38d1e90e0)] - **build**: notify via slack when review-wanted (Rafael Gonzaga) [#55102](nodejs/node#55102) - \[[`0b985ec4bb`](nodejs/node@0b985ec4bb)] - **build**: remove -v flag to reduce noise (iwuliz) [#55025](nodejs/node#55025) - \[[`09f75b27a1`](nodejs/node@09f75b27a1)] - **build**: display free disk space after build in the test-macOS workflow (iwuliz) [#55025](nodejs/node#55025) - \[[`f25760c4a2`](nodejs/node@f25760c4a2)] - **build**: add the option to generate compile_commands.json in vcbuild.bat (Segev Finer) [#52279](nodejs/node#52279) - \[[`746e78c4f3`](nodejs/node@746e78c4f3)] - ***Revert*** "**build**: upgrade clang-format to v18" (Chengzhong Wu) [#54994](nodejs/node#54994) - \[[`67834ee646`](nodejs/node@67834ee646)] - **build**: print `Running XYZ linter...` for py and yml (Aviv Keller) [#54386](nodejs/node#54386) - \[[`ae34e276a2`](nodejs/node@ae34e276a2)] - **build**: pin doc workflow to Node.js 20 (Richard Lau) [#55755](nodejs/node#55755) - \[[`d0e871a706`](nodejs/node@d0e871a706)] - **build,win**: add winget config to set up env (Hüseyin Açacak) [#54729](nodejs/node#54729) - \[[`93ac799b6b`](nodejs/node@93ac799b6b)] - **cli**: fix spacing for port range error (Aviv Keller) [#54495](nodejs/node#54495) - \[[`3ba2e7bf97`](nodejs/node@3ba2e7bf97)] - ***Revert*** "**console**: colorize console error and warn" (Aviv Keller) [#54677](nodejs/node#54677) - \[[`2f678ea53b`](nodejs/node@2f678ea53b)] - **crypto**: ensure invalid SubtleCrypto JWK data import results in DataError (Filip Skokan) [#55041](nodejs/node#55041) - \[[`5d28d98542`](nodejs/node@5d28d98542)] - **deps**: update undici to 6.20.0 (Node.js GitHub Bot) [#55329](nodejs/node#55329) - \[[`0c7f2fc421`](nodejs/node@0c7f2fc421)] - **deps**: update archs files for openssl-3.0.15+quic1 (Node.js GitHub Bot) [#55184](nodejs/node#55184) - \[[`da15e7edf5`](nodejs/node@da15e7edf5)] - **deps**: upgrade openssl sources to quictls/openssl-3.0.15+quic1 (Node.js GitHub Bot) [#55184](nodejs/node#55184) - \[[`381f1f9d08`](nodejs/node@381f1f9d08)] - **deps**: update archs files for openssl-3.0.14+quic1 (Node.js GitHub Bot) [#54336](nodejs/node#54336) - \[[`48d643f78a`](nodejs/node@48d643f78a)] - **deps**: upgrade openssl sources to quictls/openssl-3.0.14+quic1 (Node.js GitHub Bot) [#54336](nodejs/node#54336) - \[[`7b1796803b`](nodejs/node@7b1796803b)] - **deps**: update timezone to 2024b (Node.js GitHub Bot) [#55056](nodejs/node#55056) - \[[`8f1956c588`](nodejs/node@8f1956c588)] - **deps**: update acorn-walk to 8.3.4 (Node.js GitHub Bot) [#54950](nodejs/node#54950) - \[[`20501a7350`](nodejs/node@20501a7350)] - **deps**: update corepack to 0.29.4 (Node.js GitHub Bot) [#54845](nodejs/node#54845) - \[[`0f81eafecc`](nodejs/node@0f81eafecc)] - **doc**: fix Markdown linter (Antoine du Hamel) [#55344](nodejs/node#55344) - \[[`df713f0a98`](nodejs/node@df713f0a98)] - ***Revert*** "**doc**: update test context.assert" (Antoine du Hamel) [#55344](nodejs/node#55344) - \[[`fd6fc61d2c`](nodejs/node@fd6fc61d2c)] - **doc**: add pmarchini to collaborators (Pietro Marchini) [#55331](nodejs/node#55331) - \[[`b963db9ee2`](nodejs/node@b963db9ee2)] - **doc**: fix `events.once()` example using `AbortSignal` (Ivo Janssen) [#55144](nodejs/node#55144) - \[[`50b13bfb12`](nodejs/node@50b13bfb12)] - **doc**: add onboarding details for ambassador program (Marco Ippolito) [#55284](nodejs/node#55284) - \[[`27564b7811`](nodejs/node@27564b7811)] - **doc**: fix initial default value of autoSelectFamily (Ihor Rohovets) [#55245](nodejs/node#55245) - \[[`9e7be23aa5`](nodejs/node@9e7be23aa5)] - **doc**: tweak onboarding instructions (Michael Dawson) [#55212](nodejs/node#55212) - \[[`f412a029c3`](nodejs/node@f412a029c3)] - **doc**: update test context.assert (Pietro Marchini) [#55186](nodejs/node#55186) - \[[`2f7828debb`](nodejs/node@2f7828debb)] - **doc**: fix unordered error anchors (Antoine du Hamel) [#55242](nodejs/node#55242) - \[[`d08e4c235b`](nodejs/node@d08e4c235b)] - **doc**: mention addons to experimental permission (Rafael Gonzaga) [#55166](nodejs/node#55166) - \[[`d65c2458dc`](nodejs/node@d65c2458dc)] - **doc**: use correct dash in stability status (Antoine du Hamel) [#55200](nodejs/node#55200) - \[[`d9839c16cf`](nodejs/node@d9839c16cf)] - **doc**: fix link in `test/README.md` (Livia Medeiros) [#55165](nodejs/node#55165) - \[[`1ad659afa4`](nodejs/node@1ad659afa4)] - **doc**: add esm examples to node:net (Alfredo González) [#55134](nodejs/node#55134) - \[[`81ad69d50f`](nodejs/node@81ad69d50f)] - **doc**: move the YAML changes element (sendoru) [#55112](nodejs/node#55112) - \[[`7a51a161be`](nodejs/node@7a51a161be)] - **doc**: fix the require resolve algorithm in `modules.md` (chirsz) [#55117](nodejs/node#55117) - \[[`80edcdf899`](nodejs/node@80edcdf899)] - **doc**: update style guide (Aviv Keller) [#53223](nodejs/node#53223) - \[[`388c754dd2`](nodejs/node@388c754dd2)] - **doc**: add missing `:` to `run()`'s `globPatterns` (Aviv Keller) [#55135](nodejs/node#55135) - \[[`94302b6a76`](nodejs/node@94302b6a76)] - **doc**: add abmusse to collaborators (Abdirahim Musse) [#55086](nodejs/node#55086) - \[[`27ff2da964`](nodejs/node@27ff2da964)] - **doc**: add note about `--expose-internals` (Aviv Keller) [#52861](nodejs/node#52861) - \[[`df6dc753b7`](nodejs/node@df6dc753b7)] - **doc**: remove `parseREPLKeyword` from REPL documentation (Aviv Keller) [#54749](nodejs/node#54749) - \[[`4baa5c4d10`](nodejs/node@4baa5c4d10)] - **doc**: change backporting guide with updated info (Aviv Keller) [#53746](nodejs/node#53746) - \[[`9947fc112f`](nodejs/node@9947fc112f)] - **doc**: add missing definitions to `internal-api.md` (Aviv Keller) [#53303](nodejs/node#53303) - \[[`a4586f0e94`](nodejs/node@a4586f0e94)] - **doc**: update documentation for externalizing deps (Michael Dawson) [#54792](nodejs/node#54792) - \[[`70504f8522`](nodejs/node@70504f8522)] - **doc**: update `require(ESM)` history and stability status (Antoine du Hamel) [#55199](nodejs/node#55199) - \[[`9d0041ac40`](nodejs/node@9d0041ac40)] - **doc**: add release key for aduh95 (Antoine du Hamel) [#55349](nodejs/node#55349) - \[[`0c1666a52a`](nodejs/node@0c1666a52a)] - **events**: allow null/undefined eventInitDict (Matthew Aitken) [#54643](nodejs/node#54643) - \[[`453df77f99`](nodejs/node@453df77f99)] - **events**: return `currentTarget` when dispatching (Matthew Aitken) [#54642](nodejs/node#54642) - \[[`0decaab9db`](nodejs/node@0decaab9db)] - **fs**: acknowledge `signal` option in `filehandle.createReadStream()` (Livia Medeiros) [#55148](nodejs/node#55148) - \[[`00a2fc7166`](nodejs/node@00a2fc7166)] - **lib**: move `Symbol[Async]Dispose` polyfills to `internal/util` (Antoine du Hamel) [#54853](nodejs/node#54853) - \[[`8e6b606ac4`](nodejs/node@8e6b606ac4)] - **lib**: remove lib/internal/idna.js (Yagiz Nizipli) [#55050](nodejs/node#55050) - \[[`c96e5cb664`](nodejs/node@c96e5cb664)] - **lib**: the REPL should survive deletion of Array.prototype methods (Jordan Harband) [#31457](nodejs/node#31457) - \[[`748ed2e559`](nodejs/node@748ed2e559)] - **meta**: move one or more collaborators to emeritus (Node.js GitHub Bot) [#55300](nodejs/node#55300) - \[[`8b8d35f015`](nodejs/node@8b8d35f015)] - **meta**: bump mozilla-actions/sccache-action from 0.0.5 to 0.0.6 (dependabot\[bot]) [#55225](nodejs/node#55225) - \[[`d3441ff0c8`](nodejs/node@d3441ff0c8)] - **meta**: bump actions/checkout from 4.1.7 to 4.2.0 (dependabot\[bot]) [#55224](nodejs/node#55224) - \[[`1c20908558`](nodejs/node@1c20908558)] - **meta**: bump actions/setup-node from 4.0.3 to 4.0.4 (dependabot\[bot]) [#55223](nodejs/node#55223) - \[[`8a529abd69`](nodejs/node@8a529abd69)] - **meta**: bump peter-evans/create-pull-request from 7.0.1 to 7.0.5 (dependabot\[bot]) [#55219](nodejs/node#55219) - \[[`9053d210ab`](nodejs/node@9053d210ab)] - **meta**: add mailmap entry for abmusse (Abdirahim Musse) [#55182](nodejs/node#55182) - \[[`db2496c125`](nodejs/node@db2496c125)] - **meta**: add more information about nightly releases (Aviv Keller) [#55084](nodejs/node#55084) - \[[`d2ce003b2f`](nodejs/node@d2ce003b2f)] - **meta**: add `linux` to OS labels in collaborator guide (Aviv Keller) [#54986](nodejs/node#54986) - \[[`37b0bea247`](nodejs/node@37b0bea247)] - **meta**: remove never-used workflow trigger (Aviv Keller) [#54983](nodejs/node#54983) - \[[`ae27e2dcd7`](nodejs/node@ae27e2dcd7)] - **meta**: add links to alternative issue trackers (Aviv Keller) [#54401](nodejs/node#54401) - \[[`6e5d524b0f`](nodejs/node@6e5d524b0f)] - **module**: remove duplicated import (Aviv Keller) [#54942](nodejs/node#54942) - \[[`3a682cca03`](nodejs/node@3a682cca03)] - **path**: remove repetitive conditional operator in `posix.resolve` (Wiyeong Seo) [#54835](nodejs/node#54835) - \[[`ac1cb8dfdb`](nodejs/node@ac1cb8dfdb)] - **perf_hooks**: add missing type argument to getEntriesByName (Luke Taher) [#54767](nodejs/node#54767) - \[[`85b3edc83b`](nodejs/node@85b3edc83b)] - **repl**: catch `\v` and `\r` in new-line detection (Aviv Keller) [#54512](nodejs/node#54512) - \[[`df1f04999e`](nodejs/node@df1f04999e)] - **src**: decode native error messages as UTF-8 (Joyee Cheung) [#55024](nodejs/node#55024) - \[[`86d718177a`](nodejs/node@86d718177a)] - **src**: update clang-tidy and focus on modernization (Yagiz Nizipli) [#53757](nodejs/node#53757) - \[[`7d01b6a9c5`](nodejs/node@7d01b6a9c5)] - **src**: cleanup per env handles directly without a list (Chengzhong Wu) [#54993](nodejs/node#54993) - \[[`a730cdb622`](nodejs/node@a730cdb622)] - **src**: remove duplicate code setting AF_INET (He Yang) [#54939](nodejs/node#54939) - \[[`f10d9ad283`](nodejs/node@f10d9ad283)] - **stream**: treat null asyncIterator as undefined (Jason Zhang) [#55119](nodejs/node#55119) - \[[`6027084245`](nodejs/node@6027084245)] - **test**: make `test-loaders-workers-spawned` less flaky (Antoine du Hamel) [#55172](nodejs/node#55172) - \[[`66a87d19bd`](nodejs/node@66a87d19bd)] - **test**: update multiple assert tests to use node:test (James M Snell) [#54585](nodejs/node#54585) - \[[`5105188c47`](nodejs/node@5105188c47)] - **test**: update wpt test for encoding (devstone) [#55151](nodejs/node#55151) - \[[`81bcec0b82`](nodejs/node@81bcec0b82)] - **test**: deflake test/pummel/test-timers.js (jakecastelli) [#55098](nodejs/node#55098) - \[[`82c402265a`](nodejs/node@82c402265a)] - **test**: deflake test-http-remove-header-stays-removed (Luigi Pinca) [#55004](nodejs/node#55004) - \[[`78021701ed`](nodejs/node@78021701ed)] - **test**: fix test-tls-junk-closes-server (Michael Dawson) [#55089](nodejs/node#55089) - \[[`c908b8a2d8`](nodejs/node@c908b8a2d8)] - **test**: fix more tests that fail when path contains a space (Antoine du Hamel) [#55088](nodejs/node#55088) - \[[`afc1628e73`](nodejs/node@afc1628e73)] - **test**: fix `assertSnapshot` when path contains a quote (Antoine du Hamel) [#55087](nodejs/node#55087) - \[[`7c88739b83`](nodejs/node@7c88739b83)] - **test**: fix some tests when path contains `%` (Antoine du Hamel) [#55082](nodejs/node#55082) - \[[`eb4d468671`](nodejs/node@eb4d468671)] - ***Revert*** "**test**: mark test-fs-watch-non-recursive flaky on Windows" (Luigi Pinca) [#55079](nodejs/node#55079) - \[[`bc7b5249d4`](nodejs/node@bc7b5249d4)] - **test**: make `test-runner-assert` more robust (Aviv Keller) [#55036](nodejs/node#55036) - \[[`6c2a1386f7`](nodejs/node@6c2a1386f7)] - **test**: update tls test to support OpenSSL32 (Michael Dawson) [#55030](nodejs/node#55030) - \[[`96406610fa`](nodejs/node@96406610fa)] - **test**: fix `test-vm-context-dont-contextify` when path contains a space (Antoine du Hamel) [#55026](nodejs/node#55026) - \[[`39a80eed4f`](nodejs/node@39a80eed4f)] - **test**: adjust tls-set-ciphers for OpenSSL32 (Michael Dawson) [#55016](nodejs/node#55016) - \[[`bd8fd4fceb`](nodejs/node@bd8fd4fceb)] - **test**: add `util.stripVTControlCharacters` test (RedYetiDev) [#54865](nodejs/node#54865) - \[[`333b5a02d0`](nodejs/node@333b5a02d0)] - **test**: improve coverage for timer promises schedular (Aviv Keller) [#53370](nodejs/node#53370) - \[[`f48992f433`](nodejs/node@f48992f433)] - **test**: remove unused common utilities (RedYetiDev) [#54825](nodejs/node#54825) - \[[`93a098c56d`](nodejs/node@93a098c56d)] - **test**: deflake test-http-header-overflow (Luigi Pinca) [#54978](nodejs/node#54978) - \[[`f849cf677d`](nodejs/node@f849cf677d)] - **test**: fix `soucre` to `source` (Aviv Keller) [#55038](nodejs/node#55038) - \[[`1a007ea814`](nodejs/node@1a007ea814)] - **test**: add asserts to validate test assumptions (Michael Dawson) [#54997](nodejs/node#54997) - \[[`6f53c096f8`](nodejs/node@6f53c096f8)] - **test**: move test-http-max-sockets to parallel (Luigi Pinca) [#54977](nodejs/node#54977) - \[[`aba9dc775e`](nodejs/node@aba9dc775e)] - **test**: remove test-http-max-sockets flaky designation (Luigi Pinca) [#54976](nodejs/node#54976) - \[[`ee5624bffe`](nodejs/node@ee5624bffe)] - **test**: adjust key sizes to support OpenSSL32 (Michael Dawson) [#54972](nodejs/node#54972) - \[[`5c11a61140`](nodejs/node@5c11a61140)] - **test**: update test to support OpenSSL32 (Michael Dawson) [#54968](nodejs/node#54968) - \[[`62f21470e4`](nodejs/node@62f21470e4)] - **test**: update DOM events web platform tests (Matthew Aitken) [#54642](nodejs/node#54642) - \[[`426851705c`](nodejs/node@426851705c)] - **test_runner**: assert entry is a valid object (Edigleysson Silva (Edy)) [#55231](nodejs/node#55231) - \[[`b1cad519d7`](nodejs/node@b1cad519d7)] - **test_runner**: use `test:` symbol on second print of parent test (RedYetiDev) [#54956](nodejs/node#54956) - \[[`63c8f3d436`](nodejs/node@63c8f3d436)] - **test_runner**: replace ansi clear with ansi reset (Pietro Marchini) [#55013](nodejs/node#55013) - \[[`0b3fb344f7`](nodejs/node@0b3fb344f7)] - **tools**: add `polyfilled` option to `prefer-primordials` rule (Antoine du Hamel) [#55318](nodejs/node#55318) - \[[`8981309bd9`](nodejs/node@8981309bd9)] - **tools**: make `choco install` script more readable (Aviv Keller) [#54002](nodejs/node#54002) - \[[`7310abeae1`](nodejs/node@7310abeae1)] - **tools**: bump Rollup from 4.18.1 to 4.22.4 for `lint-md` (dependabot\[bot]) [#55093](nodejs/node#55093) - \[[`083311e8af`](nodejs/node@083311e8af)] - **tools**: remove redudant code from eslint require rule (Aviv Keller) [#54892](nodejs/node#54892) - \[[`ae4b2aece1`](nodejs/node@ae4b2aece1)] - **tools**: update error message for ICU in license-builder (Aviv Keller) [#54742](nodejs/node#54742) - \[[`3ebd31684d`](nodejs/node@3ebd31684d)] - **tools**: update github_reporter to 1.7.1 (Node.js GitHub Bot) [#54951](nodejs/node#54951) - \[[`397be8a10e`](nodejs/node@397be8a10e)] - **tty**: fix links for terminal colors (Aviv Keller) [#54596](nodejs/node#54596) - \[[`a3c2ef9e98`](nodejs/node@a3c2ef9e98)] - **util**: update ansi regex (Aviv Keller) [#54865](nodejs/node#54865) - \[[`efdccc88a2`](nodejs/node@efdccc88a2)] - **watch**: preserve output when gracefully restarted (Théo LUDWIG) [#54323](nodejs/node#54323) - \[[`226836c5ac`](nodejs/node@226836c5ac)] - **worker**: throw InvalidStateError in postMessage after close (devstone) [#55206](nodejs/node#55206) - \[[`f39ff4d14b`](nodejs/node@f39ff4d14b)] - **worker**: handle `--input-type` more consistently (Antoine du Hamel) [#54979](nodejs/node#54979) - \[[`30383ffb9a`](nodejs/node@30383ffb9a)] - **zlib**: throw brotli initialization error from c++ (Yagiz Nizipli) [#54698](nodejs/node#54698) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

PR-URL: nodejs#54512 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Aug 22, 2024

RedYetiDev force-pushed the patch-106 branch from 6f3a1d0 to eef9462 Compare August 23, 2024 00:05

BridgeAR approved these changes Aug 24, 2024

View reviewed changes

VoltrexKeyva approved these changes Aug 25, 2024

View reviewed changes

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2024

LiviaMedeiros approved these changes Aug 31, 2024

View reviewed changes

RedYetiDev added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Aug 31, 2024

RedYetiDev added the review wanted PRs that need reviews. label Sep 10, 2024

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 14, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 14, 2024

RedYetiDev added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed review wanted PRs that need reviews. labels Sep 19, 2024

H4ad added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 23, 2024

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 23, 2024

aduh95 reviewed Sep 23, 2024

View reviewed changes

test/parallel/test-repl-preview-newlines.js Outdated Show resolved Hide resolved

aduh95 approved these changes Sep 23, 2024

View reviewed changes

RedYetiDev and others added 4 commits September 23, 2024 19:30

repl: catch \v and \r in new-line detection

66b6cc1

disable if no inspector

19c6ac2

fixup!

84cf466

Co-authored-by: Antoine du Hamel <[email protected]>

fixup! fixup!

500c5ee

RedYetiDev force-pushed the patch-106 branch from da344b7 to 500c5ee Compare September 23, 2024 23:33

jakecastelli added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 24, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 24, 2024

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 24, 2024

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 24, 2024

aduh95 approved these changes Sep 25, 2024

View reviewed changes

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 25, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 25, 2024

nodejs-github-bot merged commit c6d20a0 into nodejs:main Sep 25, 2024
61 checks passed

aduh95 mentioned this pull request Oct 9, 2024

V22.10.0 proposal #55343

Merged

marco-ippolito mentioned this pull request Nov 16, 2024

v20.18.1 proposal #55879

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

repl: catch `\v` and `\r` in new-line detection #54512

repl: catch `\v` and `\r` in new-line detection #54512

RedYetiDev commented Aug 22, 2024

aduh95 commented Aug 22, 2024

codecov bot commented Aug 22, 2024 •

edited

Loading

mikesamuel commented Aug 22, 2024

RedYetiDev commented Aug 23, 2024

BridgeAR left a comment

VoltrexKeyva left a comment

nodejs-github-bot commented Aug 29, 2024

nodejs-github-bot commented Aug 31, 2024

RedYetiDev commented Aug 31, 2024

RedYetiDev commented Aug 31, 2024

RedYetiDev commented Sep 4, 2024 •

edited

Loading

nodejs-github-bot commented Sep 14, 2024

nodejs-github-bot commented Sep 21, 2024

RedYetiDev commented Sep 22, 2024 •

edited

Loading

nodejs-github-bot commented Sep 23, 2024

RedYetiDev commented Sep 23, 2024

nodejs-github-bot commented Sep 24, 2024

RedYetiDev commented Sep 24, 2024

nodejs-github-bot commented Sep 24, 2024

nodejs-github-bot commented Sep 25, 2024

repl: catch \v and \r in new-line detection #54512

repl: catch \v and \r in new-line detection #54512

Conversation

RedYetiDev commented Aug 22, 2024

aduh95 commented Aug 22, 2024

codecov bot commented Aug 22, 2024 • edited Loading

Codecov Report

mikesamuel commented Aug 22, 2024

RedYetiDev commented Aug 23, 2024

BridgeAR left a comment

Choose a reason for hiding this comment

VoltrexKeyva left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Aug 29, 2024

nodejs-github-bot commented Aug 31, 2024

RedYetiDev commented Aug 31, 2024

RedYetiDev commented Aug 31, 2024

RedYetiDev commented Sep 4, 2024 • edited Loading

nodejs-github-bot commented Sep 14, 2024

nodejs-github-bot commented Sep 21, 2024

RedYetiDev commented Sep 22, 2024 • edited Loading

nodejs-github-bot commented Sep 23, 2024

RedYetiDev commented Sep 23, 2024

nodejs-github-bot commented Sep 24, 2024

RedYetiDev commented Sep 24, 2024

nodejs-github-bot commented Sep 24, 2024

nodejs-github-bot commented Sep 25, 2024

repl: catch `\v` and `\r` in new-line detection #54512

repl: catch `\v` and `\r` in new-line detection #54512

codecov bot commented Aug 22, 2024 •

edited

Loading

RedYetiDev commented Sep 4, 2024 •

edited

Loading

RedYetiDev commented Sep 22, 2024 •

edited

Loading