lib: prefer logical assignment #55044

RedYetiDev · 2024-09-21T14:31:56Z

Enforces https://eslint.org/docs/latest/rules/logical-assignment-operators

IMO logical assignment operators are more concise and readable than if/then and || statements. This way, we can do more in less code, while keeping the files readable.

codecov · 2024-09-21T15:43:52Z

Codecov Report

Attention: Patch coverage is 97.08738% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.42%. Comparing base (bbdfeeb) to head (c9b98f4).
Report is 22 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/_http_server.js	75.00%	1 Missing ⚠️
lib/internal/child_process.js	50.00%	0 Missing and 1 partial ⚠️
lib/internal/test_runner/utils.js	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #55044   +/-   ##
=======================================
  Coverage   88.41%   88.42%           
=======================================
  Files         652      652           
  Lines      186612   186531   -81     
  Branches    36062    35981   -81     
=======================================
- Hits       165001   164932   -69     
+ Misses      14885    14873   -12     
  Partials     6726     6726

Files with missing lines	Coverage Δ
lib/_http_agent.js	`98.17% <100.00%> (-0.02%)`	⬇️
lib/_http_client.js	`97.96% <100.00%> (ø)`
lib/_tls_common.js	`97.43% <100.00%> (-0.02%)`	⬇️
lib/_tls_wrap.js	`93.38% <100.00%> (ø)`
lib/assert.js	`99.87% <100.00%> (ø)`
lib/async_hooks.js	`99.65% <100.00%> (ø)`
lib/child_process.js	`97.72% <100.00%> (-0.02%)`	⬇️
lib/dgram.js	`97.31% <100.00%> (-0.01%)`	⬇️
lib/events.js	`99.75% <100.00%> (-0.09%)`	⬇️
lib/internal/assert.js	`100.00% <100.00%> (ø)`
... and 32 more

... and 37 files with indirect coverage changes

nodejs-github-bot · 2024-09-21T16:43:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62645/

anonrig

This is a cosmetic change, and needs to include an eslint rule in order to land, or someone can easily change it in the future. cc @lpinca

RedYetiDev · 2024-09-21T23:19:24Z

WIP until I develop a lint rule.

RedYetiDev · 2024-09-22T00:29:57Z

@anonrig I enforced the logical-assignment-operators lint rule. Are you still blocking?

lib/_http_client.js

lib/internal/bootstrap/switches/is_not_main_thread.js

lib/internal/console/constructor.js

lib/internal/fs/utils.js

lib/internal/modules/helpers.js

tools/doc/json.mjs

anonrig · 2024-09-22T22:25:42Z

74 files is almost impossible to review for me.

lib/_tls_common.js

lib/async_hooks.js

lib/internal/fs/sync_write_stream.js

anonrig · 2024-09-22T22:27:15Z

@jasnell @trivikr @atlowChemi please rereview since the changes you approved are no longer the same.

anonrig · 2024-09-22T22:28:00Z

@RedYetiDev what is the motivation for this change, please add it to your description for reviewers

RedYetiDev · 2024-09-22T23:43:29Z

@anonrig sorry for the little mistakes in this PR, i hope it's all good now. Thank you so much for your patience (everyone really)

RedYetiDev · 2024-09-23T00:10:51Z

Okay. This should be A-OK now, could everyone have another look?

lib/events.js

lib/internal/options.js

lib/internal/streams/duplex.js

lib/internal/streams/pipeline.js

lib/internal/test_runner/coverage.js

lib/readline.js

lib/timers.js

LiviaMedeiros

LGTM.
For future PRs of this size, I'd recommend to commit fixups separately (i.e. even if rebase is required, it's better to push fixup first and then force-push it rebased on main, so it's easier to review).

RedYetiDev · 2024-10-01T20:03:42Z

Could someone restart the github CIs that failed to start?

@anonrig it's been a week, are you still blocking?

nodejs-github-bot · 2024-10-01T20:10:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62878/

RedYetiDev · 2024-10-08T19:32:58Z

Can someone approve + CI so this can land after the most recent rebase?

nodejs-github-bot · 2024-10-08T19:58:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62996/

nodejs-github-bot · 2024-10-09T06:42:17Z

Landed in 7178588

PR-URL: nodejs#55044 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 21, 2024

RedYetiDev added the lib / src Issues and PRs related to general changes in the lib or src directory. label Sep 21, 2024

jasnell approved these changes Sep 21, 2024

View reviewed changes

jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2024

atlowChemi approved these changes Sep 21, 2024

View reviewed changes

anonrig requested changes Sep 21, 2024

View reviewed changes

RedYetiDev marked this pull request as draft September 21, 2024 23:18

RedYetiDev added the wip Issues and PRs that are still a work in progress. label Sep 21, 2024

RedYetiDev force-pushed the fixup-options branch from c7f59bd to bdbc843 Compare September 22, 2024 00:21

RedYetiDev removed the wip Issues and PRs that are still a work in progress. label Sep 22, 2024

RedYetiDev requested a review from anonrig September 22, 2024 00:21

RedYetiDev marked this pull request as ready for review September 22, 2024 00:21

RedYetiDev changed the title ~~lib: simplify options lazy-loading~~ lib: prefer logical assignment Sep 22, 2024

trivikr reviewed Sep 22, 2024

View reviewed changes

RedYetiDev force-pushed the fixup-options branch from bdbc843 to 00fd177 Compare September 22, 2024 18:25

RedYetiDev requested a review from trivikr September 22, 2024 18:25

trivikr approved these changes Sep 22, 2024

View reviewed changes

RedYetiDev force-pushed the fixup-options branch 2 times, most recently from a46a373 to e795fd7 Compare September 22, 2024 21:54

anonrig reviewed Sep 22, 2024

View reviewed changes

lib/_tls_common.js Outdated Show resolved Hide resolved

lib/async_hooks.js Outdated Show resolved Hide resolved

lib/internal/fs/sync_write_stream.js Outdated Show resolved Hide resolved

RedYetiDev force-pushed the fixup-options branch from e795fd7 to 19d00f5 Compare September 22, 2024 23:41

RedYetiDev requested review from jasnell, trivikr and atlowChemi September 23, 2024 00:10

trivikr approved these changes Sep 23, 2024

View reviewed changes

atlowChemi approved these changes Sep 23, 2024

View reviewed changes

lib/events.js Outdated Show resolved Hide resolved

LiviaMedeiros reviewed Sep 25, 2024

View reviewed changes

RedYetiDev force-pushed the fixup-options branch from 227c03c to c46eb6d Compare September 25, 2024 19:09

RedYetiDev requested a review from LiviaMedeiros September 26, 2024 13:29

LiviaMedeiros approved these changes Sep 26, 2024

View reviewed changes

RedYetiDev added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2024

anonrig approved these changes Oct 1, 2024

View reviewed changes

RedYetiDev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 1, 2024

lib: prefer logical assignment

c9b98f4

RedYetiDev force-pushed the fixup-options branch from c46eb6d to c9b98f4 Compare October 5, 2024 14:10

atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2024

atlowChemi approved these changes Oct 8, 2024

View reviewed changes

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2024

atlowChemi added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2024

nodejs-github-bot merged commit 7178588 into nodejs:main Oct 9, 2024
60 checks passed

aduh95 mentioned this pull request Oct 14, 2024

2024-10-16, Version 23.0.0 (Current) #55338

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lib: prefer logical assignment #55044

lib: prefer logical assignment #55044

RedYetiDev commented Sep 21, 2024 •

edited

Loading

codecov bot commented Sep 21, 2024 •

edited

Loading

nodejs-github-bot commented Sep 21, 2024

anonrig left a comment

RedYetiDev commented Sep 21, 2024

RedYetiDev commented Sep 22, 2024

anonrig commented Sep 22, 2024

anonrig commented Sep 22, 2024 •

edited

Loading

anonrig commented Sep 22, 2024

RedYetiDev commented Sep 22, 2024

RedYetiDev commented Sep 23, 2024

LiviaMedeiros left a comment

RedYetiDev commented Oct 1, 2024

nodejs-github-bot commented Oct 1, 2024

RedYetiDev commented Oct 8, 2024

nodejs-github-bot commented Oct 8, 2024

nodejs-github-bot commented Oct 9, 2024

lib: prefer logical assignment #55044

lib: prefer logical assignment #55044

Conversation

RedYetiDev commented Sep 21, 2024 • edited Loading

codecov bot commented Sep 21, 2024 • edited Loading

Codecov Report

nodejs-github-bot commented Sep 21, 2024

anonrig left a comment

Choose a reason for hiding this comment

RedYetiDev commented Sep 21, 2024

RedYetiDev commented Sep 22, 2024

anonrig commented Sep 22, 2024

anonrig commented Sep 22, 2024 • edited Loading

anonrig commented Sep 22, 2024

RedYetiDev commented Sep 22, 2024

RedYetiDev commented Sep 23, 2024

LiviaMedeiros left a comment

Choose a reason for hiding this comment

RedYetiDev commented Oct 1, 2024

nodejs-github-bot commented Oct 1, 2024

RedYetiDev commented Oct 8, 2024

nodejs-github-bot commented Oct 8, 2024

nodejs-github-bot commented Oct 9, 2024

RedYetiDev commented Sep 21, 2024 •

edited

Loading

codecov bot commented Sep 21, 2024 •

edited

Loading

anonrig commented Sep 22, 2024 •

edited

Loading