Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test-tls-junk-closes-server #55089

Merged
merged 3 commits into from
Sep 25, 2024

Commits on Sep 23, 2024

  1. test: fix test-tls-junk-closes-server

    Refs: nodejs#53382
    
    TLS spec seems to indicate there should should be a response
    sent when TLS handshake fails. See
    https://datatracker.ietf.org/doc/html/rfc8446#page-85
    
    When compiled with OpenSSL32 we see the
    the following response '15 03 03 00 02 02 16' which
    decodes as a fatal (0x02) TLS error alert number 22 (0x16).
    which corresponds to TLS1_AD_RECORD_OVERFLOW which matches
    the error we see if NODE_DEBUG is turned on once you get
    through the define aliases.
    
    If there is a response from the server the test used to
    hang because the end event will not be emitted until after
    the response is consumed. This PR fixes the test so
    it consumes the response.
    
    Some earlier OpenSSL versions did not seem to send a response but
    the error handling seems to have been re-written/improved
    in OpenSSL32.
    
    Signed-off-by: Michael Dawson <[email protected]>
    mhdawson committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    9472340 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Update test/parallel/test-tls-junk-closes-server.js

    Co-authored-by: Mohammed Keyvanzadeh <[email protected]>
    mhdawson and VoltrexKeyva authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    0f549f4 View commit details
    Browse the repository at this point in the history
  2. Update test/parallel/test-tls-junk-closes-server.js

    Co-authored-by: Mohammed Keyvanzadeh <[email protected]>
    mhdawson and VoltrexKeyva authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    ff25b99 View commit details
    Browse the repository at this point in the history