Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test,crypto: update WebCryptoAPI WPT #55512

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

panva
Copy link
Member

@panva panva commented Oct 24, 2024

Just git node wpt WebCryptoAPI and acknowledging failures tracked in #55296 and pending decision on a spec change12

Footnotes

  1. https://github.com/w3c/webcrypto/issues/369

  2. https://github.com/w3c/webcrypto/pull/351

@panva panva added crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests. request-ci Add this label to start a Jenkins CI on a PR. webcrypto labels Oct 24, 2024
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 24, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 24, 2024
@nodejs-github-bot

This comment was marked as outdated.

@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 24, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 24, 2024
@nodejs-github-bot
Copy link
Collaborator

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.41%. Comparing base (7b5d660) to head (9e2f77a).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #55512   +/-   ##
=======================================
  Coverage   88.41%   88.41%           
=======================================
  Files         653      653           
  Lines      187476   187476           
  Branches    36083    36089    +6     
=======================================
  Hits       165763   165763           
- Misses      14946    14954    +8     
+ Partials     6767     6759    -8     

see 32 files with indirect coverage changes

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 24, 2024
@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 24, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 26, 2024
@nodejs-github-bot nodejs-github-bot merged commit c63255b into nodejs:main Oct 26, 2024
63 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in c63255b

@panva panva deleted the bump-webcrypto branch October 26, 2024 08:05
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2024
PR-URL: #55512
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
PR-URL: nodejs#55512
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
PR-URL: nodejs#55512
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. webcrypto
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants