lib: handle Float16Array in node:v8 serdes #55996
Open
+16
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
reviewed
Nov 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55996 +/- ##
==========================================
+ Coverage 87.95% 88.00% +0.04%
==========================================
Files 656 656
Lines 188304 189006 +702
Branches 35972 35992 +20
==========================================
+ Hits 165624 166334 +710
+ Misses 15853 15841 -12
- Partials 6827 6831 +4
|
bnoordhuis
approved these changes
Nov 26, 2024
Co-authored-by: Ben Noordhuis <[email protected]>
github-actions
bot
removed
the
request-ci
aduh95
reviewed
Nov 30, 2024
| @@ -31,6 +31,7 @@ const { | |||
| Uint32Array, | |||
| Uint8Array, | |||
| Uint8ClampedArray, | |||
| globalThis, | |||
There was a problem hiding this comment.
nit
Suggested change
| globalThis, | |
| globalThis: { | |
| Float16Array, | |
| }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for
Float16Arrayinnode:v8serde APIs.While
Float16Arrayis not available as a global yet (pending stabilization in V8),I "reserved" the next available index for serde purposes so other runtimes, like Deno,
that already support
Float16Array, can support it innode:v8serde APIsin a future compatible way.
Closes #55574.