Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing Node.js v18.19.0 on nodejs.org #6148

Closed
okuryu opened this issue Nov 30, 2023 · 7 comments
Closed

missing Node.js v18.19.0 on nodejs.org #6148

okuryu opened this issue Nov 30, 2023 · 7 comments
Labels

Comments

@okuryu
Copy link
Contributor

okuryu commented Nov 30, 2023

URL:

Browser Name:

any

Browser Version:

any

Operating System:

any

How to reproduce the issue:

Node.js version 18.19.0 has been released, but it seems that the information about this version has not been updated on nodejs.org.

@okuryu okuryu added the bug label Nov 30, 2023
@UlisesGascon
Copy link
Member

I confirm the bug!

The blog post entry exist as https://nodejs.org/en/blog/release/v18.19.0 but is not shown in the index, I will have a look.
Screenshot 2023-11-30 at 11 50 33

@UlisesGascon
Copy link
Member

Not sure why is not indexed, I compared the pr to others and the actions logs. 🤔

@ovflowd
Copy link
Member

ovflowd commented Nov 30, 2023

This should properly fix it: #6153

@richardlau
Copy link
Member

This should properly fix it: #6153

Still missing the posts for 18.19.0 and 20.3.0.
image

@ovflowd
Copy link
Member

ovflowd commented Nov 30, 2023

This should properly fix it: #6153

Still missing the posts for 18.19.0 and 20.3.0. image

Yup, I forgot one change, that the pages themselves also need to be invalidated over time.

@ovflowd
Copy link
Member

ovflowd commented Nov 30, 2023

Pushed as hot-fix (74c0c5e)...

Since the data is fetch at build-time and I introduced the "revalidate" on the same build, I bet they just fetched the already cached data. I wonder if a redeployment would have been enough.

But it's something we can monitor. And I can always remove the in-page revalidation if #6153 indeed was enough.

@ovflowd
Copy link
Member

ovflowd commented Nov 30, 2023

I can ack that the data is refreshed now.

@ovflowd ovflowd closed this as completed Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants