Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility Issues with Scrolling and Focus in WithSearchBox Modal #6975

Open
47anjan opened this issue Aug 2, 2024 · 2 comments · May be fixed by #6908
Open

Accessibility Issues with Scrolling and Focus in WithSearchBox Modal #6975

47anjan opened this issue Aug 2, 2024 · 2 comments · May be fixed by #6908
Labels
accessibility Issues concerning accessibility

Comments

@47anjan
Copy link

47anjan commented Aug 2, 2024

Enter your suggestions in details:

The WithSearchBox modal currently has the following accessibility issues:

  1. Accidental Scrolling: When the modal content is larger than the viewport, users can accidentally scroll the entire page behind the modal. This disrupts their focus and makes it challenging to interact with the modal content.
  2. Focus Loss: When navigating the modal using the keyboard, users might inadvertently tab past the modal boundaries and interact with elements on the underlying page. This behavior is confusing and disrupts the intended interaction with the modal.

Steps to Reproduce:

  1. Open the WithSearchBox modal.
  2. Attempt to scroll the page when the modal content exceeds the viewport size.
  3. Use the Tab key to navigate through the modal elements and observe if the focus moves to elements outside the modal.

Expected Behavior:

  1. Scrolling should be restricted to the modal content, preventing any accidental scrolling of the underlying page.
  2. Keyboard focus should be locked within the modal, ensuring that users cannot tab to elements outside the modal.

Benefits:

  • Enhances user experience by preventing accidental scrolling and focus loss.
  • Adheres to accessibility best practices, making the modal more user-friendly for all users, including those relying on keyboard navigation.

Additional Information:

Implementing these changes will significantly improve the accessibility and usability of the WithSearchBox modal. This enhancement aligns with the goal of providing an inclusive and seamless experience for all users.

@ovflowd
Copy link
Member

ovflowd commented Sep 10, 2024

Hey @anjankarmakar10 are these issues still relevant? We recently completely changed the Search Box component to one from a 3rd party, Orama.

Could you verify these issues, and if new or similar still exist, I could ask for @micheleriva to give a look into them :)

@ovflowd ovflowd added the accessibility Issues concerning accessibility label Sep 10, 2024
@micheleriva
Copy link
Contributor

Hi @ovflowd, we'll try to complete the PR for the new searchbox ASAP. It'll include a good number of bugfixes and accessibility issues. (#6908)

@bmuenzenmeyer bmuenzenmeyer linked a pull request Oct 18, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issues concerning accessibility
Projects
None yet
3 participants