-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring string_decoder into the foundation #272
Comments
is this the one browserify uses ? |
We also depend on that: https://github.com/nodejs/readable-stream/blob/master/package.json#L12 |
we also rely on process, that might be a good one to move over to the node umbrella too, that being said it's very different from string_decoder or this as it's a shim that attempts to simulate node behavior |
@calvinmetcalf I think string_decoder is lifted from core, and as such I think it should be under the foundation. process is very different, I would not touch that atm. |
I've tagged this @nodejs/ctc, as I think it's the best course of action. |
This should be reviewed by the TSC too, added label. |
@nodejs/ctc has no problem in this if @nodejs/tsc is ok with it. |
This looks familiar was there another issue where people were asked to weigh in or was that a different package ? |
ref: nodejs/TSC#260 |
@joshgav thanks, wanted to make sure I had chimed into the conversation. |
This has been done, and we can close this. |
Very recently a bug was reported to string_decoder, and @rvagg forwarded it to me. (a test is failing in node 4+).
That module uses a very similar machinery to readable-stream to keep it in sync with latest Node.js. I'm in the process of updating that as well to the latest node.js.
Speaking with @rvagg, I think it might be a good idea to move it under the nodejs github organization, and we keep that in sync together with
readable-stream
.Do you all agree it's a good idea?
The text was updated successfully, but these errors were encountered: