Missing fields on Fetch PerformanceResourceTiming instance

[Ethan-Arrowood]

Does anyone know why the PerformanceResourceTiming instance is missing information regarding DNS and what not?

Here is an example:

PerformanceResourceTiming {
    name: 'https://example.com/',
    entryType: 'resource',
    startTime: 257.69891691207886,
    duration: 98.86862516403198,
    initiatorType: 'fetch',
    nextHopProtocol: undefined,
    workerStart: 0,
    redirectStart: 0,
    redirectEnd: 0,
    fetchStart: 257.69891691207886,
    domainLookupStart: undefined,
    domainLookupEnd: undefined,
    connectStart: undefined,
    connectEnd: undefined,
    secureConnectionStart: undefined,
    requestStart: 0,
    responseStart: 0,
    responseEnd: 356.56754207611084,
    transferSize: 300,
    encodedBodySize: 0,
    decodedBodySize: 0
  }

That you get from a simple script like:

const url = new URL('https://example.com')
const res1 = await fetch(url);

await res1.text();

const fetchEntry = perfHooks.performance.getEntriesByName(url);
console.log(fetchEntry);

I tracked down the places in the source code where this gets created:

1. undici/lib/fetch/index.js

   Lines 311 to 325 in 8422aa9

   	markResourceTiming(
   	timingInfo,
   	originalURL,
   	initiatorType,
   	globalThis,
   	cacheState
   	)
   	}
   	// https://w3c.github.io/resource-timing/#dfn-mark-resource-timing
   	function markResourceTiming (timingInfo, originalURL, initiatorType, globalThis, cacheState) {
   	if (nodeMajor > 18 || (nodeMajor === 18 && nodeMinor >= 2)) {
   	performance.markResourceTiming(timingInfo, originalURL.href, initiatorType, globalThis, cacheState)
   	}
   	}

2. https://github.com/nodejs/node/blob/main/lib/internal/perf/resource_timing.js#L205-L228

But it's still not immediately clear to me how to fix this. Any ideas?

[Ethan-Arrowood]

I think I found it: https://github.com/nodejs/undici/blob/main/lib/fetch/util.js#L274-L288

These are all 0 - we need to figure out how to populate these values correctly.

[Ethan-Arrowood]

And the relevant part of the spec that would be setting some of these values (such as domainLookupStartTime (https://fetch.spec.whatwg.org/#ref-for-connection-timing-info-domain-lookup-start-time)

[Ethan-Arrowood]

Found it for real:

undici/lib/fetch/index.js

Line 1770 in c228fdd

// 9. Run these steps, but abort when the ongoing fetch is terminated:

its just not implemented.

Someone is welcome to take this on if they'd like. Otherwise I may be able to next week.

[Ethan-Arrowood]

Some relevant places to completely implement performanceresourcetiming:

• undici/lib/fetch/index.js

  Line 1770 in c228fdd

  // 9. Run these steps, but abort when the ongoing fetch is terminated:

• undici/lib/fetch/index.js

  Line 2107 in c228fdd

  // TODO: implement connection timing

[Ethan-Arrowood]

@ronag where / how would I get access to the underlying connection and dns processes for fetch? I'm trying to add those timings to the PerformanceResourceTiming instance and I can't seem to find it.

[metcoder95]

I think is not doable without using Symbols to access the Socket from the dispatcher (either through init or getting the global one).

For the DNS is even trickier, I don't think there's a way to intercept that without messing directly with the lookup option while connecting 🤔