Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move logic to interceptors #2943

Open
3 tasks
ronag opened this issue Mar 10, 2024 · 4 comments
Open
3 tasks

Move logic to interceptors #2943

ronag opened this issue Mar 10, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@ronag
Copy link
Member

ronag commented Mar 10, 2024

Once #2826 lands we can start moving some logic into interceptors in order to ensure we get similar logic for all api implementations:

  • throwOnError as interceptor
  • dump as interceptor
  • signal handling as interceptor
@ronag ronag added the enhancement New feature or request label Mar 10, 2024
@metcoder95 metcoder95 added the semver-major Features or fixes that will be included in the next semver major release label Mar 10, 2024
@metcoder95
Copy link
Member

Shall we mark them as good-first-issue?
I believe that at least two of them (signaling and throwOnError) can be done easily

@ronag ronag removed the semver-major Features or fixes that will be included in the next semver major release label Mar 10, 2024
@ronag
Copy link
Member Author

ronag commented Mar 10, 2024

I don't think this needs to be semver major.

@stu01509
Copy link

Hi @ronag

I'm interested in this topic, can I pick this?

@mcollina
Copy link
Member

go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mcollina @ronag @metcoder95 @stu01509