Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate generic impls are placed in the same namespace #3043

Closed
jfecher opened this issue Oct 9, 2023 · 0 comments · Fixed by #3087
Closed

Separate generic impls are placed in the same namespace #3043

jfecher opened this issue Oct 9, 2023 · 0 comments · Fixed by #3087
Assignees
@jfecher
Labels
bug Something isn't working

Comments

@jfecher
Copy link
Contributor

jfecher commented Oct 9, 2023

Aim

struct Foo<N> {
    x : N,
}

impl Foo<Field> {
    fn hash1(self) {}
}
impl Foo<u32> {
    fn hash1(self) {}
}

Expected Behavior

The code should compile

Bug

An error is given that hash1 is already defined.

To Reproduce

Installation Method

None

Nargo Version

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@jfecher jfecher added the bug Something isn't working label Oct 9, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Oct 9, 2023
@jfecher jfecher self-assigned this Oct 9, 2023
@jfecher jfecher mentioned this issue Oct 10, 2023
Merged
5 tasks
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfecher jfecher

Labels
bug Something isn't working
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Implement impl specialization noir-lang/noir
1 participant
@jfecher