Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nargo fmt --check functionality #3520

Closed
benesjan opened this issue Nov 21, 2023 Discussed in #3519 · 2 comments · Fixed by #3530
Closed

Add nargo fmt --check functionality #3520

benesjan opened this issue Nov 21, 2023 Discussed in #3519 · 2 comments · Fixed by #3530
Labels
nargo Noir's CLI development tool

Comments

@benesjan
Copy link
Contributor

benesjan commented Nov 21, 2023 •
edited
Loading

Problem

We would like to integrate nargo fmt in CI in aztec-packages but to do that we would need to run nargo fmt in "check-only mode" (not modifying the files and just throwing instead).

Happy Case

nargo fmt --check exits with exit code 1 when formatting issues are spotted.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Nov 21, 2023
@kevaundray
Copy link
Contributor

@f01dab1e can you take this on?

@ghost
Copy link

ghost commented Nov 21, 2023

yes, I thought about that. I guess I'll take it

@kevaundray kevaundray assigned ghost Nov 21, 2023
@kevaundray kevaundray changed the title nargo fmt --check Add nargo fmt --check functionality Nov 21, 2023
@Savio-Sou Savio-Sou added the nargo Noir's CLI development tool label Nov 21, 2023
@ghost ghost mentioned this issue Nov 22, 2023
Merged
5 tasks
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
nargo Noir's CLI development tool
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add --check option to nargo fmt for dry-run formatting verification
3 participants
@benesjan @kevaundray @Savio-Sou