You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm writing tests and I accidentally used this syntax:
#[test(should_fail_with("Arrays not equal"))]
instead of correct one:
#[test(should_fail_with = "Arrays not equal")]
Expected Behavior
I expect Noir to throw a compilation error
Bug
Test gets silently ignored. Which is very dangerous on code review as reviewer would think that this case is tested and works as the first syntax looks plausible
To Reproduce
Write the test using the first syntax
Run tests. It's ignored
Project Impact
Blocker
Impact Context
It's not a blocker, but I think it's high as it can allow for some critical vulnerabilities to go unnoticed
Workaround
Yes
Workaround Description
Use correct syntax, have linter ish script that checks for incorrect one
Additional Context
No response
Installation Method
Binary (noirup default)
Nargo Version
noirc version = 0.26.0+c46b164ce56e6a8f81255fb17eb6539bd040f336
NoirJS Version
No response
Would you like to submit a PR for this Issue?
None
Support Needs
No response
The text was updated successfully, but these errors were encountered:
Aim
I'm writing tests and I accidentally used this syntax:
#[test(should_fail_with("Arrays not equal"))]
instead of correct one:
#[test(should_fail_with = "Arrays not equal")]
Expected Behavior
I expect Noir to throw a compilation error
Bug
Test gets silently ignored. Which is very dangerous on code review as reviewer would think that this case is tested and works as the first syntax looks plausible
To Reproduce
Project Impact
Blocker
Impact Context
It's not a blocker, but I think it's high as it can allow for some critical vulnerabilities to go unnoticed
Workaround
Yes
Workaround Description
Use correct syntax, have linter ish script that checks for incorrect one
Additional Context
No response
Installation Method
Binary (
noirup
default)Nargo Version
noirc version = 0.26.0+c46b164ce56e6a8f81255fb17eb6539bd040f336
NoirJS Version
No response
Would you like to submit a PR for this Issue?
None
Support Needs
No response
The text was updated successfully, but these errors were encountered: