Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test vectors for pedersen commitments/hashes with non-zero separators #5315

Closed
TomAFrench opened this issue Jun 24, 2024 · 1 comment
Closed
Assignees

Comments

@TomAFrench
Copy link
Member

We recently ran into an issue during the Noir sync which slipped through due to a lack of tests for non-zero separators.

We should generate some test vectors using an old version of Noir prior to the removal of pedersen blackbox functions, port over the changes from this commit and ensure that the new implementation matches these values.

@guipublic
Copy link
Contributor

I added test vector in PR #5431

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants