Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run entire test suite with multiple values for inliner_aggressiveness #6390

Closed
TomAFrench opened this issue Oct 29, 2024 · 4 comments · Fixed by #6429
Closed

Run entire test suite with multiple values for inliner_aggressiveness #6390

TomAFrench opened this issue Oct 29, 2024 · 4 comments · Fixed by #6429
Assignees

Comments

@TomAFrench
Copy link
Member

We recently updated the test suite to run the stdlib tests with a range of potential inliner aggressiveness settings. In #6378 I've updated the default aggressiveness to 0 however this has resulted in a number of compilation failures.

We should update the test suite so that we run it with a range of inliner aggressiveness settings to match how we do it in the stdlib.

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Oct 29, 2024
@TomAFrench TomAFrench assigned guipublic and aakoshh and unassigned guipublic Oct 30, 2024
@aakoshh
Copy link
Contributor

aakoshh commented Nov 1, 2024

You mean literally the entire test suite, with a Github Workflow matrix strategy?
Or should we somehow identify tests that run the nargo cli?

I suppose it would help to add support for that value to come from an env var.

@aakoshh
Copy link
Contributor

aakoshh commented Nov 1, 2024

I'll look at the test failures, I see there are some tests which might work similarly to how the stdlib is decorated (and they don't use the CLI).

@TomAFrench
Copy link
Member Author

By "entire test suite" I meant everything in test_programs. We codegen the tests in this file which we can modify to pass different values for the inliner_aggressiveness CLI option.

@aakoshh
Copy link
Contributor

aakoshh commented Nov 1, 2024

I thought I saw some other kinds of test failures, can't find them now 🙈

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants