Recursively check all ValueIds returned by simplify_call match the expected type

[TomAFrench]

We've had another case of simplification of foreign calls resulting in us injecting invalid types into SSA in #6652.

In this PR @asterite raised that we should check that the returned values should have their type checked to catch any reoccurences of this issue. We did a small form of this but it only looks at the top level type, as Ary noted this won't catch any invalid types within nested types such as arrays.

This can be solved by recursively matching on the type and inspecting the inputs to MakeArray instructions so that we can make this guarantee much stronger.

We likely don't want this assertion to make it into release builds as we should have tests covering all these cases and then no user input will be able to trigger this assertion.