chore: Updating label docs workflow #1338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quick update, as this workflow is apparently only triggered by humans and ignored by github_bot. This commit attempts to fix this
signorecello
changed the title
phated
suggested changes
May 11, 2023
|
hey @phated it seems like the token being used here is DOCS_REPO_TOKEN and not GITHUB_TOKEN... I guess we're probably looking at different places? |
|
@signorecello we cannot use secrets in a workflow that is on the pull_request event. Those can be exfiltrated by any user that wants to send a PR and curl it off somewhere. You'll need to find a different solution. |
TomAFrench
reviewed
May 23, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick update, as this workflow is apparently only triggered by humans and ignored by github_bot. This commit attempts to fix this
Description
Summary of changes
Adds another trigger "pull_request", as apparently "pull_request_target" is excluding github_bot. Pull request is usually labeled by github_bot, making the counterpart issues in the docs not being created
Documentation needs