Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Extend compiler memory report to external repos #6768

Open
wants to merge 151 commits into
base: master
Choose a base branch
from

Conversation

vezenovm
Copy link
Contributor

@vezenovm vezenovm commented Dec 10, 2024

Description

Problem*

Followup to #6750

Summary*

This report essentially copies the process in #6750 for recording additional benchmarks from external repos. I made two new jobs external_repo_memory_report and upload_memory_report. I debating making the uploading and the uploading of the compilation report to be one job but I decided it would be better to keep them separate.

Additional Context

The memory report job for noir-contracts takes ~29 minutes with ~9G for peak memory. I commented it out for now due to the time it takes and was not sure we would want to be running this on every job.

I was thinking it may be best to simply generate benchmark reports for external repos only when specified by the label run-external-checks, similar to our testing of external repos.

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

github-actions bot commented Dec 10, 2024

Compilation Sample

Program Compilation Time %
sha256_regression 0m1.494s -2%
regression_4709 0m1.565s 1%
ram_blowup_regression 0m17.079s 1%
private-kernel-reset 0m9.591s 2%
private-kernel-inner 0m2.382s -10%
parity-root 0m0.902s -6%
noir-contracts 2m46.267s -2%

Copy link
Contributor

github-actions bot commented Dec 11, 2024

Peak Memory Sample

Program Peak Memory
keccak256 81.38M
workspace 122.05M
regression_4709 333.59M
ram_blowup_regression 2.55G
private-kernel-tail 232.49M
private-kernel-reset 1.24G
private-kernel-inner 338.32M
parity-root 199.36M

@vezenovm vezenovm marked this pull request as ready for review December 11, 2024 04:51
Base automatically changed from mv/compilation-report-external to master December 11, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants