-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): Extend compiler memory report to external repos #6768
Open
vezenovm
wants to merge
151
commits into
master
Choose a base branch
from
mv/mem-report-external-repos
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+164
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into mv/compilation-report-external
Compilation Sample
|
vezenovm
commented
Dec 11, 2024
Peak Memory Sample
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Followup to #6750
Summary*
This report essentially copies the process in #6750 for recording additional benchmarks from external repos. I made two new jobs
external_repo_memory_report
andupload_memory_report
. I debating making the uploading and the uploading of the compilation report to be one job but I decided it would be better to keep them separate.Additional Context
The memory report job for
noir-contracts
takes ~29 minutes with ~9G for peak memory. I commented it out for now due to the time it takes and was not sure we would want to be running this on every job.I was thinking it may be best to simply generate benchmark reports for external repos only when specified by the label
run-external-checks
, similar to our testing of external repos.Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.