Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile fails #5

Open
paulirish opened this issue Sep 14, 2017 · 0 comments
Open

Compile fails #5

paulirish opened this issue Sep 14, 2017 · 0 comments

Comments

@paulirish
Copy link

paulirish commented Sep 14, 2017

trying this out today and was seeing some problems:

❯ yarn generate-crdp
yarn generate-crdp v1.0.1
$ tsc -p src/tsconfig.json && node out/protocolToCrdp.js
src/protocolToCrdp.ts(1,22): error TS6053: File '~/code/temp/chrome-remote-debug-protocol/typings/index.d.ts' not found.
src/protocolToCrdp.ts(3,21): error TS2307: Cannot find module 'fs'.
src/protocolToCrdp.ts(4,23): error TS2307: Cannot find module 'path'.
src/protocolToCrdp.ts(224,25): error TS2304: Cannot find name '__dirname'.
error Command failed with exit code 2.

The missing modules I fixed with a yarn add @types/node.

The ../typings/index.d.ts reference though.. I'm still noob enough with TSC to not know the right fix. Though admittedly commenting it out seems to work... :)

I pushed my changes (with a protocol bump) to my fork. I'll open it as a PR just so you can see. Feel free to close it if you want: #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant