From 23cea0293fc7c3e2a2c58704da8bae3fb3d92a74 Mon Sep 17 00:00:00 2001 From: Arctic Ice Studio Date: Tue, 11 Feb 2020 13:44:09 +0100 Subject: [PATCH] Fix invisible background color of inactive completion popup item (#118) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Before this commit, the background color of the marked entry in the completion popup when triggered while typing (enabled "Show suggestions as you type" option in preferences) [1] was the same like the background of the popup itself. As a result, the user did not know which entry was selected to complete the current line. The problem only occurred when the completion popup was triggered while typing but not when being explicitly invoked using the configured keymapping [2] (`Ctrl` / `⌃` + `Space` by default). This was because when the popup is invoked while typing, the matching entry in the list is "inactive", but the color for inactive entries was the same like the background color of the popup itself. This problem is now fixed by changing the color of the corresponding UI theme key `ui.CompletionPopup.selectionInactiveBackground` from `nord1` to `nord3`. [1]: https://www.jetbrains.com/help/idea/auto-completing-code.html#configure-code-completion [2]: https://www.jetbrains.com/help/idea/auto-completing-code.html#invoke-basic-completion Related to GH-94 Fixes GH-95 --- src/nord.theme.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/nord.theme.json b/src/nord.theme.json index a771615..11daeb6 100644 --- a/src/nord.theme.json +++ b/src/nord.theme.json @@ -85,7 +85,7 @@ "matchSelectionForeground": "#88c0d0", "nonFocusedState": "#2e3440", "selectionBackground": "#4c566a", - "selectionInactiveBackground": "#3b4252", + "selectionInactiveBackground": "#4c566a", "selectionInactiveInfoForeground": "#4c566a", "selectionInfoForeground": "#eceff4" },