-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Theme not showing in PhpStorm 2019.1 #46
Comments
Compiling from source should work fine. |
Are there any instructions on how to compile from source? Unfortunately, there is no section in the README. |
No there aren't.
|
Big thanks to you!! Btw what icon theme are you using? (Sorry for OT, but it looks really awesome) :) |
@axelitus Thanks for the detailed guide 👍 , I've planned to add one to the README but postponed it until all docs and assets are moved over to the website. There are some references and descriptions in #43 including links to official guides from JetBrains that I've used to transform the theme into a plugin. |
I found that guide and it served me as a basis, but I still struggled to know what I was doing (or should be doing) because I had never used IntelliJ, nor build a Jetbrain Plugin. So I wanted to give a step-by-step for newcomers like me. I think (but I have not tested, nor am I sure) the same could be done as in previous versions that pack certain files directly into a jar (as a jar is basically a zip, it could be as easy as to zip the needed files in the needed structure and rename the file with .jar extension). Don't know if the build process does something different though, so maybe even IntelliJ is not needed. |
For all of you who don't want to go through all the hassle of the IntelliJ way I've created a bash script that packages the plugin: https://gist.github.com/axelitus/15186e4da4a39cced9d59dc885964db8 Just download it to the nord-jetbrains source code folder, give it execute permissions and run: ./build.sh It requires either the It mimics what IntelliJ does (create an out folder with a specific structure and package it in a jar) so it should be fully compatible if you have it set up as a project in IntelliJ. |
@arcticicestudio Previously there was a Was it because it did not make it through the theme->plugin conversion? Or was it something else? |
The build script was removed because it is not necessary anymore and won't include auto-generated metadata that'll be added to the JAR file. There are also some checks that run when IntelliJ packages the plugin files like a correct Plugin XML ID and plugin icons. Anyway, I'll add the guide to the Nord website if users want to play around with the plugin or modify it. |
Also the latest version 0.5.0 has been deployed to the plugin repository and will be available when the plugin passes the upload checks. Please note that it is required to uninstall and install the plugin again if you're using a version of the theme less or equal to 0.4.0 since the Plugin XML ID was changed to match the naming scheme. Please see the release announcement on Twitter and additional info tweet for some more details. I close this issue for now since it should work fine for all IDEs including PhpStorm as soon as the plugin update is available. |
Agreed, the manual installation was just because the repository version wasn't updated. Once its published this shouldn't be needed. |
I am still being offered 0.4.0 in the marketplace, is it normal for it to take this long to process? |
@mattfletcher Please note that it is required to uninstall and install the plugin again if you're using a version of the theme less or equal to 0.4.0 since the Plugin XML ID was changed to match the naming scheme. Please see the release announcement on Twitter and additional info tweet for some more details. |
@axelitus As of Nord Docs version 0.12.0 the docs and assets of Nord JetBrains have been migrated. There's also a development guide now for users who like to customize the plugin or build it from source. |
I have installed Nord Color Scheme in PhpStorm 2019.1 and the UI theme option is not shown in the dropdown:
![image](https://user-images.githubusercontent.com/732441/56599698-b10a2580-65bc-11e9-9ef1-bc3e545a709e.png)
The Editor color scheme works fine.
The text was updated successfully, but these errors were encountered: