From 4f808c88aa474f4d94a37e0b8f700bf33a395f7c Mon Sep 17 00:00:00 2001 From: Arctic Ice Studio Date: Sun, 21 Jul 2019 09:17:21 +0200 Subject: [PATCH] Rename theme file to enable theme development features An undocumented feature for theme extension developers is to ensure the name of the JSON file is suffixed with `-color-theme.json`. This enables the JSON scheme validation for the theme API allowing developers to validate the implemented theme keys, showing warnings about deprecated keys and providing full auto completion, field documentations and color previews (color picker) for the HEX format. This change aligns Nord to the official bundled and default themes (1) by adapting to the naming scheme without being a breaking change since the theme is identified by it's extension ID as well as the `_metadata` field in the `package.json` and not by the name of the theme file (which would be odd since a theme can provide multiple theme files). References: (1) https://github.com/microsoft/vscode/tree/master/extensions/theme-abyss/themes (2) https://github.com/svipas Extracted from GH-143 submitted by @svipas (2) Resolves GH-148 --- package.json | 2 +- themes/{nord.json => nord-color-theme.json} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename themes/{nord.json => nord-color-theme.json} (100%) diff --git a/package.json b/package.json index ba6d9c1..f45d21c 100644 --- a/package.json +++ b/package.json @@ -59,7 +59,7 @@ { "label": "Nord", "uiTheme": "vs-dark", - "path": "./themes/nord.json" + "path": "./themes/nord-color-theme.json" } ] }, diff --git a/themes/nord.json b/themes/nord-color-theme.json similarity index 100% rename from themes/nord.json rename to themes/nord-color-theme.json