From 6ec692f35d2ca6a558ebaadca9c9ad882e648d22 Mon Sep 17 00:00:00 2001 From: svipas Date: Fri, 14 Jun 2019 22:31:54 +0300 Subject: [PATCH 1/7] Add missing meta.brace.round scope --- themes/nord.json | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/themes/nord.json b/themes/nord.json index 6c7cebd..1df7d3d 100644 --- a/themes/nord.json +++ b/themes/nord.json @@ -414,6 +414,13 @@ "foreground": "#ECEFF4" } }, + { + "name": "Meta Brace Round", + "scope": "meta.brace.round", + "settings": { + "foreground": "#ECEFF4" + } + }, { "name": "Punctuation Definition Parameters", "scope": [ From ed0e351726961ea57856b447342cd9ca866f98c2 Mon Sep 17 00:00:00 2001 From: svipas Date: Thu, 20 Jun 2019 17:28:16 +0300 Subject: [PATCH 2/7] Rename nord.json to nord-color-theme.json - It would show color palette, warnings/errors, etc. when the file is opened. --- package.json | 2 +- themes/{nord.json => nord-color-theme.json} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename themes/{nord.json => nord-color-theme.json} (100%) diff --git a/package.json b/package.json index bf0ee55..92daa8c 100644 --- a/package.json +++ b/package.json @@ -59,7 +59,7 @@ { "label": "Nord", "uiTheme": "vs-dark", - "path": "./themes/nord.json" + "path": "./themes/nord-color-theme.json" } ] }, diff --git a/themes/nord.json b/themes/nord-color-theme.json similarity index 100% rename from themes/nord.json rename to themes/nord-color-theme.json From 7f176117b2404c624419bf43ec5c03f0166577d0 Mon Sep 17 00:00:00 2001 From: svipas Date: Thu, 20 Jun 2019 19:04:59 +0300 Subject: [PATCH 3/7] Remove editorActiveLineNumber.foreground --- themes/nord-color-theme.json | 1 - 1 file changed, 1 deletion(-) diff --git a/themes/nord-color-theme.json b/themes/nord-color-theme.json index 1df7d3d..236d519 100644 --- a/themes/nord-color-theme.json +++ b/themes/nord-color-theme.json @@ -22,7 +22,6 @@ "dropdown.background": "#3b4252", "dropdown.border": "#3b4252", "dropdown.foreground": "#d8dee9", - "editorActiveLineNumber.foreground": "#d8dee9cc", "editorCursor.foreground": "#d8dee9", "editorHint.border": "#ebcb8b00", "editorHint.foreground": "#ebcb8b", From c5c60496cefcc68e7fef635cc971406778a0c88f Mon Sep 17 00:00:00 2001 From: svipas Date: Thu, 20 Jun 2019 19:06:10 +0300 Subject: [PATCH 4/7] Replace editorWidgetBorder --- themes/nord-color-theme.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/themes/nord-color-theme.json b/themes/nord-color-theme.json index 236d519..e14a79e 100644 --- a/themes/nord-color-theme.json +++ b/themes/nord-color-theme.json @@ -31,7 +31,7 @@ "editorLineNumber.activeForeground": "#d8dee9", "editorWhitespace.foreground": "#4c566ab3", "editorWidget.background": "#2e3440", - "editorWidgetBorder": "#3b4252", + "editorWidget.border": "#3b4252", "editor.background": "#2e3440", "editor.foreground": "#d8dee9", "editor.hoverHighlightBackground": "#3b4252", From cb28e2143f9461dbdba3b4b282403a61e600a020 Mon Sep 17 00:00:00 2001 From: svipas Date: Thu, 20 Jun 2019 19:07:02 +0300 Subject: [PATCH 5/7] Replace editorGroup.background --- themes/nord-color-theme.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/themes/nord-color-theme.json b/themes/nord-color-theme.json index e14a79e..2739f5d 100644 --- a/themes/nord-color-theme.json +++ b/themes/nord-color-theme.json @@ -53,7 +53,7 @@ "editorBracketMatch.background": "#2e344000", "editorBracketMatch.border": "#88c0d0", "editorCodeLens.foreground": "#4c566a", - "editorGroup.background": "#2e3440", + "editorGroup.emptyBackground": "#2e3440", "editorGroup.border": "#3b425201", "editorGroup.dropBackground": "#3b425299", "editorGroupHeader.noTabsBackground": "#2e3440", From 866188584b774cc2127787ad03ed4ffcef08af7e Mon Sep 17 00:00:00 2001 From: svipas Date: Thu, 20 Jun 2019 19:08:19 +0300 Subject: [PATCH 6/7] Remove legacy support of notification - Also, increase min. version of VS Code. --- package.json | 2 +- themes/nord-color-theme.json | 15 --------------- 2 files changed, 1 insertion(+), 16 deletions(-) diff --git a/package.json b/package.json index 92daa8c..7ccb5e3 100644 --- a/package.json +++ b/package.json @@ -19,7 +19,7 @@ }, "license": "MIT", "engines": { - "vscode": "^1.12.0" + "vscode": "^1.21.0" }, "galleryBanner": { "color": "#2E3440", diff --git a/themes/nord-color-theme.json b/themes/nord-color-theme.json index 2739f5d..cabb9b3 100644 --- a/themes/nord-color-theme.json +++ b/themes/nord-color-theme.json @@ -128,20 +128,6 @@ "merge.incomingHeaderBackground": "#8fbcbb66", "merge.incomingContentBackground": "#8fbcbb4d", "merge.border": "#3b425200", - - /* `notification.*` keys are legacy support for VS Code versions >1.21.0 */ - "notification.background": "#3b4252", - "notification.buttonBackground": "#434c5e", - "notification.buttonForeground": "#d8dee9", - "notification.buttonHoverBackground": "#4c566a", - "notification.errorBackground": "#bf616a", - "notification.errorForeground": "#2e3440", - "notification.foreground": "#d8dee9", - "notification.infoBackground": "#88c0d0", - "notification.infoForeground": "#2e3440", - "notification.warningBackground": "#ebcb8b", - "notification.warningForeground": "#2e3440", - "notificationCenter.border": "#3b425200", "notificationCenterHeader.background": "#2e3440", "notificationCenterHeader.foreground": "#88c0d0", @@ -150,7 +136,6 @@ "notifications.border": "#2e3440", "notifications.foreground": "#d8dee9", "notificationToast.border": "#3b425200", - "panel.background": "#2e3440", "panel.border": "#3b4252", "panelTitle.activeBorder": "#88c0d000", From 2fe22e8b3fda16e34ca96e65bdc3016334a480dd Mon Sep 17 00:00:00 2001 From: svipas Date: Thu, 20 Jun 2019 19:11:22 +0300 Subject: [PATCH 7/7] Revert: Add missing meta.brace.round scope --- themes/nord-color-theme.json | 7 ------- 1 file changed, 7 deletions(-) diff --git a/themes/nord-color-theme.json b/themes/nord-color-theme.json index cabb9b3..1e40244 100644 --- a/themes/nord-color-theme.json +++ b/themes/nord-color-theme.json @@ -398,13 +398,6 @@ "foreground": "#ECEFF4" } }, - { - "name": "Meta Brace Round", - "scope": "meta.brace.round", - "settings": { - "foreground": "#ECEFF4" - } - }, { "name": "Punctuation Definition Parameters", "scope": [