Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overridden ESLint "import/no-extraneous-dependencies" rule #41

Closed
arcticicestudio opened this issue Nov 24, 2018 · 0 comments
Closed

Comments

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Nov 24, 2018

The import/no-extraneous-dependencies rule allows to define a array of glob pattern that are allowed to define import devDependencies. In #15 the rule was overridden to include the project specific path **/.gatsby/** which whitelists all Gatsby specific scripts. Unfortunately this removes all glob pattern defined in the used eslint-config-arcticicestudio (rule is defined in the -base package) resulting in errors in other projects paths like tests.
This can be fixed by importing the paths defined in the preset from the eslint-config-arcticicestudio-base package and merge it with the additional **/.gatsby/** path.

@arcticicestudio arcticicestudio added this to the 0.1.0 milestone Nov 24, 2018
@arcticicestudio arcticicestudio self-assigned this Nov 24, 2018
@arcticicestudio arcticicestudio changed the title Fix overriden ESLint "import/no-extraneous-dependencies" rule Fix overridden ESLint "import/no-extraneous-dependencies" rule Nov 24, 2018
@arcticicestudio arcticicestudio removed their assignment Nov 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant