New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go1.7 vet dislikes MemoryFileStore #792

Closed

gtank opened this issue Jun 17, 2016 · 0 comments

Contributor

gtank commented Jun 17, 2016

$ go version
go version go1.7beta1 linux/amd64
$ make
pkcs11 import was not found anywhere without a build tag, yay
+ clean
+ fmt
+ vet
trustmanager/keyfilestore.go:213: literal copies lock value from *memStore: trustmanager.MemoryFileStore
Makefile:94: recipe for target 'vet' failed
make: *** [vet] Error 1

The sync.Mutex in MemoryFileStore might be unnecessary anyway, since KeyMemoryStore provides its own locking.

The text was updated successfully, but these errors were encountered:

gtank mentioned this issue

remove literal copy of sync.Mutex from memory store #793

Merged

gtank closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment