Notary client interface type #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Lawrence <[email protected]> (github: endophage)
… arg Signed-off-by: Riyaz Faizullabhoy <[email protected]>
|
Thanks for wrapping up the last bits of cleanup on this. Will review once CI passes. |
HuKeping
reviewed
Sep 4, 2017
| return filepath.Walk(sourceDir, func(fp string, fi os.FileInfo, err error) error { | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| targetFP := filepath.Join(targetDir, strings.TrimPrefix(fp, sourceDir+"/")) |
There was a problem hiding this comment.
Happy to see we finally get rid of the +"/"
|
Haven't check it line by line, but I like the design |
client/interface.go
Outdated
| // Key Operations | ||
| RotateKey(role data.RoleName, serverManagesKey bool, keyList []string) error | ||
|
|
||
| CryptoService() signed.CryptoService |
There was a problem hiding this comment.
s/CryptoService/GetCryptoService/g
|
LGTM after nit on GetCryptoService(). |
NathanMcCauley
approved these changes
Sep 7, 2017
Signed-off-by: Riyaz Faizullabhoy <[email protected]>
riyazdf
force-pushed
the
notary-client-interface-type
branch
from
b28e526 to
62788b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repositoryinterface to standardizeclient.NotaryRepositoryInitializeWithCertificateto not take a notary repository as an argumentPart of #1139, originally stolen from
endophage/client_interfacebranch