Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about encoding #51

Closed
seobyeongky opened this issue Jan 21, 2015 · 2 comments · Fixed by #55
Closed

about encoding #51

seobyeongky opened this issue Jan 21, 2015 · 2 comments · Fixed by #55

Comments

@seobyeongky
Copy link

Hi, I am using gift on my server.
It is a nice package and everything good.
But there is one problem.
I put commit messages with Korean.
Commit messages are malformed.
I can't read it!
I found gift uses child_process.exec with binary encoding.
I tested with utf-8 encoding, and it works fine for just commit messages.
I think there is a reason for binary encoding, So I don't know how to fix this issue.
Any suggestion?

@notatestuser
Copy link
Owner

According to the commit where this was introduced (5af25bc) binary encoding is used to retrieve the content of binary files. The encoding scheme could be configurable as an option to work around this problem.

@seobyeongky
Copy link
Author

OK. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants