Tests on OSX. #27
Merged
Tests on OSX. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Back from holiday! This looks awesome :) I'll run/test on Linux and |
| latency: 0.1, | ||
| flags: fs::kFSEventStreamCreateFlagFileEvents, | ||
| latency: 0.0, | ||
| flags: fs::kFSEventStreamCreateFlagFileEvents | fs::kFSEventStreamCreateFlagNoDefer, |
There was a problem hiding this comment.
Out of curiosity, can you explain what that change does?
There was a problem hiding this comment.
Defer will wait several event to aggregate them and deliver to the callback. This can mess tests (at least) and this seems to be a reasonable default, until somebody tells us this messes things. Same goes with latency.
|
We also need to have @jakerr added to the Cargo.toml. |
|
And finally, could you rebase on top of master? I've added OS X Travis CI testing, let's see what that does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests now pass on OSX (necessary to reproduce #23 ).
validate_recvmethod to match results in test cases and timeout (solves Tests hang if no events are received #26 ).validate_recvto support aggregated events:op::CREATE|op::REMOVEwill match[op::CREATE, op::REMOVE](useful when your observing api can split or merge nearby events). Fixes a huge issue for OSX testing, has probably no impact on Linux.pollwatchtest is now broken on OSX because of this full path stuff (worth another bug ? sibling of Errors when watcher backend is given broken symlinks #21 ?)