Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set WatchMask::OPEN on inotify #612

Merged
merged 1 commit into from
Jul 14, 2024
Merged

Conversation

y5c4l3
Copy link
Contributor

@y5c4l3 y5c4l3 commented Jul 2, 2024

This fixes the problem of Access(Open(_)) variant not being reported.

The event variant is constructed, but watchmask does not have WatchMask::OPEN set.

if event.mask.contains(EventMask::OPEN) {
evs.push(
Event::new(EventKind::Access(AccessKind::Open(
AccessMode::Any,
)))
.add_some_path(path.clone()),
);
}

This fixes the problem of `Access(Open(_))` variant not being reported.

Signed-off-by: y5c4l3 <[email protected]>
@0xpr03
Copy link
Member

0xpr03 commented Jul 3, 2024

Can you mention which issue this is referring to ?

@y5c4l3
Copy link
Contributor Author

y5c4l3 commented Jul 4, 2024

Can you mention which issue this is referring to ?

@0xpr03 I don't think there is an issue for the problem. I encountered it and it was a quick fix, so I directly made a pull request.

@0xpr03 0xpr03 merged commit ae69a5c into notify-rs:main Jul 14, 2024
13 checks passed
@0xpr03
Copy link
Member

0xpr03 commented Jul 14, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants