chore: set workspace engines

This align all private workspaces to the same engines as the CLI and all public workspaces to ^16.14.0 || >=18.0.0
npm · Sep 15, 2023 · 826f3f0 · 826f3f0
1 parent b9e7fa1
commit 826f3f0
Show file tree

Hide file tree

Showing 9 changed files with 29 additions and 16 deletions.
diff --git a/.github/workflows/ci-libnpmfund.yml b/.github/workflows/ci-libnpmfund.yml
@@ -111,9 +111,7 @@ jobs:
             os: windows-latest
             shell: cmd
         node-version:
-          - 14.17.0
-          - 14.x
-          - 16.13.0
+          - 16.14.0
           - 16.x
           - 18.0.0
           - 18.x

diff --git a/.github/workflows/ci-npmcli-config.yml b/.github/workflows/ci-npmcli-config.yml
@@ -111,9 +111,7 @@ jobs:
             os: windows-latest
             shell: cmd
         node-version:
-          - 14.17.0
-          - 14.x
-          - 16.13.0
+          - 16.14.0
           - 16.x
           - 18.0.0
           - 18.x

diff --git a/.github/workflows/ci-npmcli-mock-globals.yml b/.github/workflows/ci-npmcli-mock-globals.yml
@@ -66,10 +66,9 @@ jobs:
             os: windows-latest
             shell: cmd
         node-version:
-          - 16.14.0
-          - 16.x
-          - 18.0.0
+          - 18.17.0
           - 18.x
+          - 20.5.0
           - 20.x
     runs-on: ${{ matrix.platform.os }}
     defaults:

diff --git a/.github/workflows/ci-npmcli-mock-registry.yml b/.github/workflows/ci-npmcli-mock-registry.yml
@@ -66,10 +66,9 @@ jobs:
             os: windows-latest
             shell: cmd
         node-version:
-          - 16.14.0
-          - 16.x
-          - 18.0.0
+          - 18.17.0
           - 18.x
+          - 20.5.0
           - 20.x
     runs-on: ${{ matrix.platform.os }}
     defaults:

diff --git a/docs/package.json b/docs/package.json
@@ -43,7 +43,7 @@
     "lib/"
   ],
   "engines": {
-    "node": "^16.14.0 || >=18.0.0"
+    "node": "^18.17.0 || >=20.5.0"
   },
   "tap": {
     "timeout": 600,

diff --git a/mock-globals/package.json b/mock-globals/package.json
@@ -30,7 +30,7 @@
     "lib/"
   ],
   "engines": {
-    "node": "^16.14.0 || >=18.0.0"
+    "node": "^18.17.0 || >=20.5.0"
   },
   "templateOSS": {
     "//@npmcli/template-oss": "This file is partially managed by @npmcli/template-oss. Edits may be overwritten.",

diff --git a/mock-registry/package.json b/mock-registry/package.json
@@ -30,7 +30,7 @@
     "lib/"
   ],
   "engines": {
-    "node": "^16.14.0 || >=18.0.0"
+    "node": "^18.17.0 || >=20.5.0"
   },
   "templateOSS": {
     "//@npmcli/template-oss": "This file is partially managed by @npmcli/template-oss. Edits may be overwritten.",

diff --git a/scripts/template-oss/pkg.json b/scripts/template-oss/pkg.json
@@ -0,0 +1,14 @@
+{
+  "engines": {
+    "node":
+      {{! Set the CLI and private workspaces to the same version }}
+      {{~#if isRoot~}}
+      "^18.17.0 || >=20.5.0"
+      {{~else~}}{{~#if isPrivate~}}
+      "^18.17.0 || >=20.5.0"
+      {{~else~}}
+      {{! All public workspaces get this version }}
+      "^16.14.0 || >=18.0.0"
+      {{~/if~}}{{~/if~}}
+  }
+}
diff --git a/scripts/template-oss/root.js b/scripts/template-oss/root.js
@@ -2,6 +2,7 @@ module.exports = {
   rootModule: {
     add: {
       'CONTRIBUTING.md': false,
+      'package.json': { file: 'pkg.json', overwrite: false },
     },
   },
   rootRepo: {
@@ -27,7 +28,11 @@ module.exports = {
       '.github/workflows/pull-request.yml': false,
     },
   },
-  ciVersions: ['18.17.0', '18.x', '20.5.0', '20.x'],
+  workspaceModule: {
+    add: {
+      'package.json': { file: 'pkg.json', overwrite: false },
+    },
+  },
   lockfile: true,
   npm: '.',
   defaultBranch: 'latest',
-Original file line number
+Diff line change
@@ Expand Up / @@ -111,9 +111,7 @@ jobs: @@
                 os: windows-latest
                 shell: cmd
             node-version:
-              - 14.17.0
-              - 14.x
-              - 16.13.0
+              - 16.14.0
               - 16.x
               - 18.0.0
               - 18.x
@@ Expand Down @@