Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prioritize CLI flags over publishConfig settings #7321

Merged
merged 6 commits into from
Apr 9, 2024

Conversation

roni-berlin
Copy link
Contributor

This PR addresses an issue where CLI flags were not taking precedence over publishConfig settings. To ensure CLI flags have higher priority, properties from the publishConfig object that also exist in CLI flags are filtered out.

Related to #6400

@roni-berlin roni-berlin requested a review from a team as a code owner March 27, 2024 19:23
@wraithgar
Copy link
Member

Welcome back! The new behavior is going to need tests.

@roni-berlin
Copy link
Contributor Author

Welcome back! The new behavior is going to need tests.

I added the tests

@wraithgar wraithgar self-assigned this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants