fix: file dependency is locked without name #7228
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR currently only contains a reproduction test case for #6430. I have looked into it a bit, but was unable to find a fix for the issue.
It seems like this condition is causing the issue. Because on the first
npm install
orreify()
call the condition is not met becausenode.packageName
andnode.name
are both equal to@test/a
and thereforenode.name
is not set for thefile:a
dependency. But on the secondnpm install
orreify()
call the condition is met becausenode.packageName
is equal to@test/a
andnode.name
is equal toa
. Therefore, thenode.name
is set to@test/a
and thepackage-lock.json
will change.cli/workspaces/arborist/lib/shrinkwrap.js
Lines 232 to 238 in d04111d
Can someone help me to fix this issue?
References
Fixes #6430