Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: adds --ignore-scripts flag to pack #7850

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Conversation

reggi
Copy link
Contributor

@reggi reggi commented Oct 17, 2024

What

This pr bumps pacote which will honor ignoreScripts opt passed in through the cli. In addition it adds --ignore-scripts as a flag to the pack command ignore the prepare script.

Why

People expect --ignore-scripts to... ignore the lifecycle scripts in package.json, which it does for all lifecycle scripts except for prepare, which runs during pack, and publish.

integrating: npm/pacote#407
from: #7211
part of: npm/statusboard#898

@reggi reggi force-pushed the reggi/ignore-scripts4 branch 3 times, most recently from 4f26f54 to 9fa1577 Compare October 17, 2024 19:24
@reggi reggi changed the title temp feat!: adds --ignore-scripts flag to pack Oct 17, 2024
@reggi reggi marked this pull request as ready for review October 17, 2024 19:31
@reggi reggi requested a review from a team as a code owner October 17, 2024 19:31
@reggi reggi force-pushed the reggi/ignore-scripts4 branch 2 times, most recently from f16df11 to 4a2e481 Compare October 17, 2024 20:17
@reggi reggi closed this Oct 17, 2024
@reggi reggi reopened this Oct 17, 2024
@reggi reggi force-pushed the reggi/ignore-scripts4 branch 3 times, most recently from 55b04b0 to 0b6941e Compare November 21, 2024 19:37
BREAKING CHANGE: `--ignore-scripts` now applies to all lifecycle scripts, include `prepare`
@wraithgar wraithgar merged commit 6995303 into latest Nov 21, 2024
84 checks passed
@wraithgar wraithgar deleted the reggi/ignore-scripts4 branch November 21, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants