Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

allow users to star packages with an auth token #92

Merged
merged 2 commits into from
Jan 16, 2015
Merged

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Jan 13, 2015

Let a user star with their auth-token, important for registry-2.0.

@othiym23 othiym23 merged commit 3b174b7 into master Jan 16, 2015
@othiym23 othiym23 deleted the bcoe/token-stars branch January 16, 2015 02:28
@othiym23
Copy link
Contributor

Squashed and some mild stylistic tweaks made before merging to master.

@thom4parisot
Copy link

Which means we could eventually do npm star @myorg/mypackage --registry=https://<token>@my.registry.example.com? :-)

@bcoe
Copy link
Contributor Author

bcoe commented Jan 30, 2015

@oncletom that should work, although I believe we have some of the listing endpoints currently locked down in npm Enterprise.

I know that stars are likely one of the most sought after features for the Enterprise, so don't hesitate to open issues surrounding this feature ;)

@othiym23
Copy link
Contributor

@oncletom Just a quick note: npm uses the credentials for a given scope when making requests, and for those credentials to be sent with npm --registry requests, you have to have logged into that registry using npm login --scope --registry so that the necessary configuration information can be set up in your .npmrc. Just putting the token in the URL is probably never going to work with npm.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants