fix: Do not blow up if the opts object is mutated #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pacote has a use case where the integrity value may not be known at the outset, but is later established, either via the dist.integrity in a packument, or by the x-local-hash header value when make-fetch-happen loads a response from the cache. In these cases, we have already started an integrity stream at the beginning of the request, and don't get the expected integrity until _after_ the integrity stream is created, resulting in a spurious EINTEGRITY error. This patch makes ssri responsive to (and resilient against) updates to the integrity and size options after the stream has started.
This is going to be used in Pacote to upgrade the Fetcher.integrity value with the data that comes out of cacache, but in such a way that we don't accidentally suppress integrity errors.
mikemimik
reviewed
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pacote has a use case where the integrity value may not be known at the
outset, but is later established, either via the dist.integrity in a
packument, or by the x-local-hash header value when make-fetch-happen
loads a response from the cache.
In these cases, we have already started an integrity stream at the
beginning of the request, and don't get the expected integrity until
after the integrity stream is created, resulting in a spurious
EINTEGRITY error.
This patch makes ssri responsive to (and resilient against) updates to
the integrity and size options after the stream has started.