Address breaking engine change in dependency #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
changed the title
|
I updated the PR title to NOT be semantically correct as an extra signal for us to remember to rebase merge this, not squash. The first commit has the correct subject and body for the changelog for the breaking change. |
wraithgar
reviewed
Jul 30, 2024
|
CI linting failure is a known bug in template-oss that has since been fixed. Ironically it's one of the things that #136 would fix, but we can't land it cause of the engines issue that THIS pr is fixing. |
node 14.17.0 no longer works due to isaacs/minipass@1270e6a BREAKING CHANGE: `ssri` is now compatible with the following semver range for node: `^16.13.0 || >=18.0.0`
hashtagchris
force-pushed
the
hashtagchris-node-prefix
branch
from
f39e29a to
4f02df0
Compare
hashtagchris
force-pushed
the
hashtagchris-node-prefix
branch
from
4f02df0 to
70f9d7d
Compare
wraithgar
approved these changes
Jul 30, 2024
Merged
hashtagchris
added a commit
to npm/template-oss
that referenced
this pull request
Aug 5, 2024
<!-- What / Why --> <!-- Describe the request in detail. What it does and why it's being changed. --> A breaking change footer like the one below is over 100 characters, resulting in commitlint CI failures. ``` BREAKING CHANGE: `ssri` is now compatible with the following semver range for node: `^16.13.0 || >=18.0.0` ``` ## References <!-- Examples: Related to #0 Depends on #0 Blocked by #0 Fixes #0 Closes #0 --> Example CI failure: https://github.com/npm/ssri/actions/runs/10169599799/job/28126863705#step:7:12 Associated PR: npm/ssri#137
hashtagchris
added a commit
to npm/template-oss
that referenced
this pull request
Aug 5, 2024
<!-- What / Why --> <!-- Describe the request in detail. What it does and why it's being changed. --> Our breaking change footers related to engine changes are often >100 characters, resulting in commitlint CI failures. <!-- Examples: Related to #0 Depends on #0 Blocked by #0 Fixes #0 Closes #0 --> Example CI failure: https://github.com/npm/ssri/actions/runs/10169599799/job/28126863705#step:7:12 Associated PR: npm/ssri#137
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node 14.17.0 no longer works due to
nodeprefixes being added in isaacs/minipass@1270e6aReferences
node 14.17.0 build break: https://github.com/npm/ssri/actions/runs/10049925593/job/27776871923