From bb48cd07634e59cb33a48318c73c88f51cce8b79 Mon Sep 17 00:00:00 2001 From: Colum Ferry Date: Wed, 6 Nov 2024 16:55:10 +0000 Subject: [PATCH] fix(rspack): use NX_GRAPH_CREATION to bail out of withWeb early --- packages/rspack/src/plugins/utils/apply-web-config.ts | 2 +- .../src/plugins/nx-webpack-plugin/lib/apply-web-config.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/rspack/src/plugins/utils/apply-web-config.ts b/packages/rspack/src/plugins/utils/apply-web-config.ts index fce9de94706b3..7d92391c79ec2 100644 --- a/packages/rspack/src/plugins/utils/apply-web-config.ts +++ b/packages/rspack/src/plugins/utils/apply-web-config.ts @@ -32,7 +32,7 @@ export function applyWebConfig( useNormalizedEntry?: boolean; } = {} ): void { - if (!process.env['NX_TASK_TARGET_PROJECT']) return; + if (!process.env['NX_GRAPH_CREATION']) return; // Defaults that was applied from executor schema previously. options.runtimeChunk ??= true; // need this for HMR and other things to work diff --git a/packages/webpack/src/plugins/nx-webpack-plugin/lib/apply-web-config.ts b/packages/webpack/src/plugins/nx-webpack-plugin/lib/apply-web-config.ts index 56af4f17b6ab9..27a094d9ea3e0 100644 --- a/packages/webpack/src/plugins/nx-webpack-plugin/lib/apply-web-config.ts +++ b/packages/webpack/src/plugins/nx-webpack-plugin/lib/apply-web-config.ts @@ -35,7 +35,7 @@ export function applyWebConfig( useNormalizedEntry?: boolean; } = {} ): void { - if (!process.env['NX_TASK_TARGET_PROJECT']) return; + if (!process.env['NX_GRAPH_CREATION']) return; // Defaults that was applied from executor schema previously. options.runtimeChunk ??= true; // need this for HMR and other things to work