From dc99e6403b83bdf70a1b58b129bc67dd99dfdee6 Mon Sep 17 00:00:00 2001 From: Colum Ferry Date: Wed, 6 Nov 2024 19:38:57 +0000 Subject: [PATCH] fix(rspack): use global.NX_GRAPH_CREATION correctly --- packages/rspack/src/plugins/utils/apply-web-config.ts | 2 +- .../src/plugins/nx-webpack-plugin/lib/apply-web-config.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/rspack/src/plugins/utils/apply-web-config.ts b/packages/rspack/src/plugins/utils/apply-web-config.ts index f2be11a654580..54f8036ec8262 100644 --- a/packages/rspack/src/plugins/utils/apply-web-config.ts +++ b/packages/rspack/src/plugins/utils/apply-web-config.ts @@ -32,7 +32,7 @@ export function applyWebConfig( useNormalizedEntry?: boolean; } = {} ): void { - if (!process.env['NX_GRAPH_CREATION']) return; + if (global.NX_GRAPH_CREATION) return; // Defaults that was applied from executor schema previously. options.runtimeChunk ??= true; // need this for HMR and other things to work diff --git a/packages/webpack/src/plugins/nx-webpack-plugin/lib/apply-web-config.ts b/packages/webpack/src/plugins/nx-webpack-plugin/lib/apply-web-config.ts index 27a094d9ea3e0..7451509093100 100644 --- a/packages/webpack/src/plugins/nx-webpack-plugin/lib/apply-web-config.ts +++ b/packages/webpack/src/plugins/nx-webpack-plugin/lib/apply-web-config.ts @@ -35,7 +35,7 @@ export function applyWebConfig( useNormalizedEntry?: boolean; } = {} ): void { - if (!process.env['NX_GRAPH_CREATION']) return; + if (global.NX_GRAPH_CREATION) return; // Defaults that was applied from executor schema previously. options.runtimeChunk ??= true; // need this for HMR and other things to work