angular library generator generates wrong eslint config

[mattlewis92]

Current Behavior

Using the @nx/angular:library generator creates an .eslintrc.json that looks like this (note we have not yet migrated our repo to flat eslint config, .eslintrc.js is still using the legacy format):

{
  "extends": ["../../.eslintrc.js"],
  "ignorePatterns": ["!**/*"],
  "overrides": [
    {
      "files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
      "rules": {}
    },
    {
      "files": ["*.ts", "*.tsx"],
      "rules": {}
    },
    {
      "files": ["*.js", "*.jsx"],
      "rules": {}
    },
    {
      "files": ["*.json"],
      "parser": "jsonc-eslint-parser",
      "rules": {
        "@nx/dependency-checks": "error"
      }
    }
  ]
}

Expected Behavior

The eslint config that gets generated looks more like this:

{
  "extends": ["../../.eslintrc.js"],
  "ignorePatterns": ["!**/*"],
  "overrides": [
    {
      "files": ["*.ts"],
      "extends": [
        "plugin:@nx/angular",
        "plugin:@angular-eslint/template/process-inline-templates"
      ],
      "rules": {
        "@angular-eslint/directive-selector": [
          "error",
          {
            "type": "attribute",
            "prefix": "cu",
            "style": "camelCase"
          }
        ],
        "@angular-eslint/component-selector": [
          "error",
          {
            "type": "element",
            "prefix": "cu",
            "style": "kebab-case"
          }
        ]
      }
    },
    {
      "files": ["*.html"],
      "extends": ["plugin:@nx/angular-template"],
      "rules": {}
    }
  ]
}

GitHub Repo

https://github.com/mattlewis92/nx-eslint-repro

Steps to Reproduce

1. Change repo root eslint config format from .eslintrc.json to .eslintrc.js
2. Run nx generate @nx/angular:library foo
3. Verify that libs/foo/.eslintrc.json is wrong

Nx Report

>  NX   Report complete - copy this into the issue template

   Node   : 20.10.0
   OS     : darwin-arm64
   pnpm   : 8.12.1
   
   nx (global)        : 16.10.0
   nx                 : 17.2.7
   @nx/js             : 17.2.7
   @nx/jest           : 17.2.7
   @nx/eslint         : 17.2.7
   @nx/workspace      : 17.2.7
   @nx/angular        : 17.2.7
   @nx/cypress        : 17.2.7
   @nx/devkit         : 17.2.7
   @nx/eslint-plugin  : 17.2.7
   @nx/node           : 17.2.7
   @nx/plugin         : 17.2.7
   @nx/react          : 17.2.7
   @nx/rollup         : 17.2.7
   @nx/storybook      : 17.2.7
   @nrwl/tao          : 16.10.0
   @nx/web            : 17.2.7
   nx-cloud           : 16.5.2
   typescript         : 5.1.3
   ---------------------------------------
   Community plugins:
   @compodoc/compodoc                             : 1.1.18
   @fortawesome/angular-fontawesome               : 0.11.1
   @jscutlery/semver                              : 4.1.0
   @ngneat/spectator                              : 15.0.1
   @ngrx/effects                                  : 16.0.1
   @ngrx/entity                                   : 16.0.1
   @ngrx/eslint-plugin                            : 16.0.1
   @ngrx/router-store                             : 16.0.1
   @ngrx/schematics                               : 16.0.1
   @ngrx/store                                    : 16.0.1
   @ngrx/store-devtools                           : 16.0.1
   @rx-angular/cdk                                : 16.0.0
   @rx-angular/state                              : 16.0.0
   @rx-angular/template                           : 16.1.1
   @storybook/angular                             : 7.5.3
   @testing-library/angular                       : 13.4.0
   @time-loop/angular-platform-browser-perf-patch : 16.2.1
   @time-loop/ngx-bootstrap                       : 3.2.0
   angular-calendar                               : 0.30.1
   ng-mocks                                       : 14.11.0
   ngx-deploy-npm                                 : 7.1.0
   ---------------------------------------
   Local workspace plugins:
         @cu/nx-plugin-workspace-generators
         @cu/nx-plugin-esbuild
   ---------------------------------------
   The following packages should match the installed version of nx
     - @nrwl/[email protected]
   
   To fix this, run `nx migrate [email protected]`

Failure Logs

No response

Package Manager Version

No response

Operating System

• macOS
• Linux
• Windows
• Other (Please specify)

Additional Information

If it is not possible to easily detect if the root eslint config is flat or not, a simple option we could pass to the library generator like is-using-flat-eslint-config=false would be great.

[Coly010]

@mattlewis92 I apologize that this has taken a while to get back to. Can you confirm if this is still an issue with the latest version of Nx?

[mattlewis92]

@mattlewis92 I apologize that this has taken a while to get back to. Can you confirm if this is still an issue with the latest version of Nx?

Hey @Coly010, I just upgraded the repo to the latest nx and am still able to reproduce the issue

[Coly010]

@mattlewis92 I talked to the team about this and the support for flat config is still in progress.

I'm going to close this issue and refer you to this issue instead which is tracking the work: #27451

[github-actions]

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.