feat(react): update app and lib generators to support new TS solution setup #28808
+3,059
−526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 573b4cd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
jaysoo
force-pushed
the
feat/ts-solution-react
branch
9 times, most recently
from
a454c45
to
a2e9734
Compare
4 tasks
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx [email protected] my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-28808-0f14212
To request a new release for this pull request, mention someone from the Nx team or the |
jaysoo
force-pushed
the
feat/ts-solution-react
branch
from
0f14212
to
e812720
Compare
jaysoo
changed the title
jaysoo
force-pushed
the
feat/ts-solution-react
branch
from
4f67272
to
18a3a8b
Compare
jaysoo
force-pushed
the
feat/ts-solution-react
branch
from
18a3a8b
to
ca32248
Compare
jaysoo
requested review from
a team,
Coly010,
FrozenPandaz,
vsavkin and
AgentEnder
as code owners
…tup for the react stack
…nfig.app.json__tmpl__ Co-authored-by: Nicholas Cunningham <[email protected]>
…config.app.json__tmpl__ Co-authored-by: Nicholas Cunningham <[email protected]>
…sconfig.app.json__tmpl__ Co-authored-by: Nicholas Cunningham <[email protected]>
Co-authored-by: Leosvel Pérez Espinosa <[email protected]>
Co-authored-by: Leosvel Pérez Espinosa <[email protected]>
Co-authored-by: Leosvel Pérez Espinosa <[email protected]>
Co-authored-by: Leosvel Pérez Espinosa <[email protected]>
Co-authored-by: Leosvel Pérez Espinosa <[email protected]>
Co-authored-by: Leosvel Pérez Espinosa <[email protected]>
Co-authored-by: Leosvel Pérez Espinosa <[email protected]>
jaysoo
force-pushed
the
feat/ts-solution-react
branch
from
41aa4e0
to
a9a1b13
Compare
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx [email protected] my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-28808-a9a1b13
To request a new release for this pull request, mention someone from the Nx team or the |
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx [email protected] my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-28808-8717441
To request a new release for this pull request, mention someone from the Nx team or the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates app and lib generators in the following packages such that they will generate files with the TS solution setup if it is detected.
@nx/react@nx/next@nx/remix@nx/expo@nx/react-nativeReact apps and libs will be linked using npm/pnpm/yarn/bun workspaces feature rather than through tsconfig paths. This means that local aliases like
@/will work with Next.js and Remix apps.Note: This will be behind
--workspacesflag when usingnpx create-nx-workspaceand choosing React stack. If you use the None/TS stack then adding plugins likenx add @nx/reactthen generating apps, it will automatically pick up the new TS solution setup.Current Behavior
React generators are not compatible with TS solution setup (i.e. workspaces + TS project references).
Expected Behavior
React generators work with new TS solution setup (Plain, Next.js, Remix, Expo, React Native).
Related Issue(s)
#28322