Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(misc)!: only provide default value for object properties if object already has value #28838

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(misc)!: only provide default value for object properties if object already has value #28838

wants to merge 1 commit into from

Commits on Nov 7, 2024

  1. fix(misc)!: only provide default value for object properties if objec… 

    …t already has value

Defaults causing an object to be defined causes some confusing behavior when a schema has defaults and required properties for a given object prop. If the required prop doesn't have a default value, and another property does, it becomes invalid to not pass the object when it would be valid had that default not been specified.

BREAKING CHANGE: Currently if an executor's schema provides some default values for an object's properties, those defaults cause the object to be defined. This changes that, such that the defaults are only applied if the object exists in the first place.
    @AgentEnder
    AgentEnder committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    eea5c4b View commit details
    Browse the repository at this point in the history