chore(core): warn when db cache is disabled #28929
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 41067ac. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
FrozenPandaz
requested changes
Nov 14, 2024
| ) { | ||
| // TODO (@AgentEnder): Insert correct link after @isaacplmann has written the documentation. | ||
| logger.warn( | ||
| `Nx is using the filesystem cache instead of the db cache. There are some limitations and trade-offs to consider when using the filesystem cache. Read more at https://nx.dev/{insert-link-here}.` |
There was a problem hiding this comment.
I think we can call it the legacy cache and mention that it will be removed in Nx 21. Instruct them to start looking into moving to the new db based cache.
| process.env.NX_REJECT_UNKNOWN_LOCAL_CACHE === 'false' | ||
| ) { | ||
| logger.warn( | ||
| 'NX_REJECT_UNKNOWN_LOCAL_CACHE=0 is not supported with the new db cache. If you were using this environment variable to suppress warnings about unrecognized cache artifacts you may be interested in Nx PowerPack. Read more at https://nx.dev/powerpack.' |
There was a problem hiding this comment.
I think this shouldn't point to powerpack directly. It should point to a page about the problem.. which should point them to Nx Cloud or Powerpack to achieve what they want.
AgentEnder
force-pushed
the
chore/warn-on-legacy-cache
branch
3 times, most recently
from
b7ebaea
to
7a950c2
Compare
AgentEnder
force-pushed
the
chore/warn-on-legacy-cache
branch
from
7a950c2
to
41067ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #