feat(core): transition daemon from queue to transaction based messaging #28983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgentEnder
requested review from
a team,
FrozenPandaz and
vsavkin
as code owners
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 155844f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AgentEnder
force-pushed
the
daemon-parallel-processing
branch
from
686e04a
to
0b4924b
Compare
AgentEnder
force-pushed
the
daemon-parallel-processing
branch
from
0b4924b
to
7cc7547
Compare
AgentEnder
force-pushed
the
daemon-parallel-processing
branch
from
7cc7547
to
155844f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The daemon uses a serial queue to communicate with individual Nx processes. This can slow things down if things inside of a
promise.allor similar method call the daemon multiple times, as all calls must wait for the prior call to finish before starting.Expected Behavior
The daemon utilizes a transaction based message system, such that it can respond to a message which arrived later if its able to complete quicker
Related Issue(s)
Fixes #