Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove manual confirmation after each batch (or make it optional) #37

Open
ththvseo opened this issue Feb 15, 2018 · 2 comments
Open

remove manual confirmation after each batch (or make it optional) #37

ththvseo opened this issue Feb 15, 2018 · 2 comments

Comments

@ththvseo
Copy link

both query and upsert interactively ask the user for confirmation after each batch of entries:

ok, err := core.ConfirmYesNoWithDefault("Do you want to output more entities?", true)

msg := fmt.Sprintf("Do you want to upsert more entities (No.%d - No.%d)? ", from+1, to)

this is kind of silly, especially when batch-processing (large amounts of) data.

it should be removed or at least made optional.

if the intention is to make interactive use more covenient,
it could maybe be enabled/disabled automatically enabled only for interactive sessions:
https://rosettacode.org/wiki/Check_output_device_is_a_terminal#Go

@nshmura
Copy link
Owner

nshmura commented Feb 17, 2018

👍
the url is very informative。
I will consider about batch-processing.

@ggalmazor
Copy link

I would add to this an option to always overwrite output file to avoid having to interactively answer that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants