Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract migrate \ update naming #128

Closed
alexvanin opened this issue Sep 20, 2021 · 2 comments · Fixed by #129
Closed

Contract migrate \ update naming #128

alexvanin opened this issue Sep 20, 2021 · 2 comments · Fixed by #129
Assignees
Labels
question Further information is requested
Milestone

Comments

@alexvanin
Copy link
Contributor

All contracts besides NNS have Migrate method that call Update method of native management contract. NNS contract use Update method. Migrate name origins from timer.go example.

It will be a bit more convenient to have the same signature for contract update methods, I guess. Maybe it will be better to use Update in all contracts because it corresponds with management contract call. Thoughts?

/cc @fyrchik @roman-khimov @AnnaShaleva

@AnnaShaleva
Copy link
Member

I don't see something that prevents us from renaming, and I also consider it's good to have unified methods naming that follows the Management's one. So I vote for Update.

@roman-khimov
Copy link
Member

I think Migrate comes from Neo Legacy where it did have some meaning, data needed to be moved from one contract (with old hash) to another (with new hash). Now Update is more correct for N3 because contract's storage or hash doesn't change, it's just an update of code and/or manifest. @AnnaShaleva, we can do the same renaming in neo-go for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants