Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What should happen when domain expires #268

Open
alexvanin opened this issue Sep 16, 2022 · 3 comments
Open

What should happen when domain expires #268

alexvanin opened this issue Sep 16, 2022 · 3 comments
Labels
I4 No visible changes question Further information is requested S2 Regular significance U4 Nothing urgent

Comments

@alexvanin
Copy link
Contributor

alexvanin commented Sep 16, 2022

I suggest to discuss it there and then move issue to a proper repository.

All domains, including top level domains, have expiration parameter. One day sooner or later all domains will expire. Now NNS stores in domain records:

  • external contract addresses,
  • system contract addresses,
  • container aliases.

According to the code, container alias should live for 1 week. Not sure it works this way, but anyway.

defaultExpire = 604800 // 1 week

I can't find any Renew invocation by alphabet nodes. I suppose alphabet nodes should create multi signed transaction and renew all available domains once in a while. If not, then I expect that one day the whole system is going to be completely broken. Are my concerns

Is it correct or am I mistaken somewhere?

@alexvanin
Copy link
Contributor Author

@realloc @fyrchik Consider moving or creating new issue in the neofs-node to control renew process by Alphabet.

@alexvanin
Copy link
Contributor Author

alexvanin commented Nov 23, 2022

container zone is registered by container contract during deployment. Therefore admin of this zone is container contract itself. It means that renew method can be invoked only by container contract.

Consider adding Renew method in container contract that invokes renew method in NNS.

/cc @fyrchik

@roman-khimov
Copy link
Member

We had this happen on mainnet (contract domain expiration, kills IR easily) and it required a manual fix, btw. The fix from #296 is just a ticking bomb for any installation.

@roman-khimov roman-khimov added question Further information is requested U4 Nothing urgent S2 Regular significance I4 No visible changes labels Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I4 No visible changes question Further information is requested S2 Regular significance U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

2 participants